track finish reason in stream processing and update message accordingly#516
Merged
ilvalerione merged 1 commit intoneuron-core:3.xfrom Mar 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Gemini/Vertex AI blocks content via safety filters mid-stream, the final chunk contains a finishReason of SAFETY.
The streaming path was silently discarding this value, so
AssistantMessage::stopReason()always returned null after streaming making it impossible to distinguish a normal completion from a moderation block.finishReasonfrom each stream chunk (the last value seen is authoritative)$message->setStopReason()on the returnedAssistantMessageafter the stream loopreadLinevisibility from private to protected to allow subclassing without full duplication