fix(get_model_data): Parse model_card instead of spec #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request updates the workflow "get_model_data", where now it parses the "model_card.yaml" instead of "spec.yaml".
A live version of this update can be found on my fork's page: https://gaiborjosue.github.io/trained-models-fork/
In the URL above, the only model card showing up is DeepCSR, this is because DeepCSR is the only model with a "model_card.yaml". Thus, we first need to add model_card.yaml to every model before merging this pull request, so the website displays the correct values.
The major updates go towards the javascript file, but I also updated the extraction of the clone directory in the workflow.
This Pull request will close #106