-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Korean keyboard file #3593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean keyboard file #3593
Conversation
metalefty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer use ini for keymap files.
|
Okay. Close this pr. Have a nice day. |
|
@lancard - are you able to build from source? If so, we might be able to get a modern keyboard file sorted for you. |
|
It’s possible. I can help if needed. Although it’s only been a few days, I’m creating a lightweight Docker for a Korean X Window environment using xrdp. Many Koreans have shown interest. If you’re interested, please share your thoughts. |
|
We're always interested in getting xrdp into new environments. I can easily generate a new-style toml file for you to try based on the These are easier to debug. Once this is done, we can backport the toml file to an ini file for xrdp v0.10.x. That's more complicated. We have to do it this way to make sure your keyboard is in the next major release of xrdp. You can get a rough idea of the process by looking at #3518 and #3519 which was a Latvian keyboard we recently added. If you're interested, let me know and I'll build a branch off devel with a Korean toml keyboard in it. |
|
Got it. I’ll take a look around. I’ll let you know when I’m ready. |
|
I've looked around, and I can do it. I'd appreciate it if you could make a branch. |
|
Hi @lancard I've been looking into Korean keyboards, and I can't find a lot of information in a language I can read on the web. My favourite reference for keyboards (https://www.kbdlayout.info/) doesn't mention your keyboard variant at all. Do you have a target keyboard working on a Linux machine somewhere? If so, what does this command tell you:- There are a number of options for Korean keyboards which can be set, and I don't know which ones correspond to the keyboard you are looking for. Thanks. |
|
As i mentioned, https://github.com/lancard/xwindow-korean/blob/master/user-entrypoint.sh refers keyboard layout. |
|
That's great - thanks! |
|
See #3598 Branch is at https://github.com/matt335672/xrdp/tree/korean_keyboard I'm making the assumption that the 106 Key Korean keyboard reports itself as type 8 as specified in [MS-RDPBCGR] 2.2.1.3.2 Client Core Data . This should get the keyboard mappings working correctly for the xorgxrdp backend. @lancard - can you try this out and let me know how it goes? |
|
sounds great. will write comment. |
add 'km-e0010412.ini' file into instfiles.