forked from x0b/rcx
-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Actions to recognize bad libraries #250
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| name: "Verify dependency chain" | ||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
|
|
||
| jobs: | ||
| dependency-change-verification: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| changed: ${{ steps.changeDetection.outputs.should-run }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v44 | ||
| - name: Verify build.gradle changed | ||
| id: changeDetection | ||
| env: | ||
| ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }} | ||
| run: | | ||
| GRADLE='build.gradle' | ||
| for file in ${ALL_CHANGED_FILES}; do | ||
| if [[ "$file" == *"$GRADLE" ]]; then | ||
| echo "$file was changed" | ||
| echo "should-run=true" >> $GITHUB_OUTPUT | ||
| fi | ||
| done | ||
|
|
||
| verify-dependencies: | ||
| runs-on: ubuntu-latest | ||
| needs: dependency-change-verification | ||
| if: needs.dependency-change-verification.outputs.changed == 'true' | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Read Go version from project | ||
| run: echo "GO_VERSION=$(grep -E "^de\.felixnuesse\.extract\.goVersion=" gradle.properties | cut -d'=' -f2)" | ||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'temurin' | ||
| cache: gradle | ||
| - name: Set up Go from gradle.properties | ||
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: '${{env.GO_VERSION}}' | ||
| id: go | ||
| - name: Setup Android SDK/NDK | ||
| uses: android-actions/setup-android@v3 | ||
| - name: Install NDK from gradle.properties | ||
| run: | | ||
| NDK_VERSION="$(grep -E "^de\.felixnuesse\.extract\.ndkVersion=" gradle.properties | cut -d'=' -f2)" | ||
| sdkmanager "ndk;${NDK_VERSION}" | ||
| - name: Build app | ||
| run: ./gradlew assembleOssDebug | ||
|
|
||
| - name: 'Check for non-FOSS libraries' | ||
| run: | | ||
| # prepare scanapk with apktool. | ||
| wget https://github.com/iBotPeaches/Apktool/releases/download/v$apktoolVersion/apktool_$apktoolVersion.jar | ||
| # Wrapper for apktool_*.jar | ||
| wget https://github.com/iBotPeaches/Apktool/raw/master/scripts/linux/apktool | ||
| # clone izzy's repo with the scan tools | ||
| git clone https://gitlab.com/IzzyOnDroid/repo.git | ||
| # create a directory for Apktool and move the apktool* files there | ||
| mkdir -p repo/lib/radar/tool | ||
| mv apktool* repo/lib/radar/tool | ||
| chmod u+x repo/lib/radar/tool/apktool | ||
| mv repo/lib/radar/tool/apktool_$apktoolVersion.jar repo/lib/radar/tool/apktool.jar | ||
| repo/bin/scanapk.php app/build/outputs/apk/oss/debug/roundsync_v*-oss-universal-debug.apk | ||
| env: | ||
| apktoolVersion: "2.9.3" | ||
| - name: 'Get Commit Hash' | ||
| id: commit | ||
| uses: pr-mpt/actions-commit-hash@v1 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| name: Translations | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| string-change-verification: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| changed: ${{ steps.changeDetection.outputs.should-run }} | ||
| files: ${{ steps.changeDetection.outputs.files }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Get changed files | ||
| id: changed-files | ||
| uses: tj-actions/changed-files@v44 | ||
| - name: Verify build.gradle changed | ||
| id: changeDetection | ||
| env: | ||
| ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }} | ||
| run: | | ||
| SEARCH='strings.xml' | ||
| CHANGEDFILES='' | ||
| for file in ${ALL_CHANGED_FILES}; do | ||
| if [[ "$file" == *"$SEARCH" ]]; then | ||
| echo "$file was changed" | ||
| CHANGEDFILES="${CHANGEDFILES} $file" | ||
| echo "should-run=true" >> $GITHUB_OUTPUT | ||
| fi | ||
| done | ||
| echo "files=$CHANGEDFILES" >> $GITHUB_OUTPUT | ||
|
|
||
| checkTranslations: | ||
| runs-on: ubuntu-latest | ||
| needs: string-change-verification | ||
| if: needs.string-change-verification.outputs.changed == 'true' | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Prepare Profanity Check | ||
| id: prep | ||
| run: | | ||
| sudo apt-get install -y xmlstarlet | ||
| pip3 install alt-profanity-check | ||
| chmod +x ./scripts/checkProfanity.py | ||
| chmod +x ./scripts/generateFilelist.sh | ||
| FILE_LIST="${{needs.string-change-verification.outputs.files}}" | ||
| SIZE=$(echo "$FILE_LIST" | awk '{print NF}') | ||
| if [ "$SIZE" -ne 1 ]; then | ||
| echo "Only pass the amount of commits and one translation file! You passed: $SIZE" | ||
| exit 1 | ||
| fi | ||
| TRANSLATIONS=$(./scripts/generateFilelist.sh ${{ github.event.pull_request.commits }} ${{needs.string-change-verification.outputs.files}}) | ||
| echo "TRANSLATIONS=$TRANSLATIONS" >> $GITHUB_OUTPUT | ||
| shell: sh | ||
| - uses: fabasoad/translation-action@main | ||
| id: google-translate | ||
| with: | ||
| provider: google | ||
| lang: auto-en | ||
| source: ${{ steps.prep.outputs.TRANSLATIONS }} | ||
| - name: Print the result | ||
| run: | | ||
| echo "Translations are: '${{ steps.google-translate.outputs.text }}'" | ||
| echo "${{ steps.google-translate.outputs.text }}" | sed 's/ ; /\n/g' > translated_texts.txt | ||
| ./scripts/checkProfanity.py translated_texts.txt | ||
| shell: sh | ||
| - name: Upload Raw Translations | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: Translations | ||
| path: | | ||
| changed_texts.txt | ||
| translated_texts.txt | ||
| suspicious_texts.txt | ||
| - name: Fail if there are suspected profanities | ||
| run: | | ||
| if [ -s "suspicious_texts.txt" ]; then | ||
| echo "We found suspicious translations. Please check!" | ||
| exit 1 | ||
| fi | ||
| shell: sh | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #!/usr/bin/python | ||
|
|
||
| from profanity_check import predict, predict_prob | ||
| import sys | ||
|
|
||
|
|
||
| file = open("suspicious_texts.txt", "a") | ||
| source = open(sys.argv[1], "r") | ||
| lines = source.readlines() | ||
| for line in lines: | ||
| print("Checking: "+str(line.rstrip())) | ||
| prediction = predict_prob([line.rstrip()]) | ||
| if prediction[0] > 0.5: | ||
| file.write(str(prediction[0]) + " - " + str(line.rstrip())+"\n") | ||
| print("Offending line: "+str(line.rstrip())) | ||
|
|
||
| file.close() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #!/bin/bash | ||
|
|
||
| if [ "$#" -ne 2 ]; then | ||
| echo "Only pass the amount of commits and one translation file!" | ||
| exit 1 | ||
| fi | ||
|
|
||
| DIFF=$(git diff -U0 HEAD~$1 ${@:2} | grep -E "^\+" | grep -v +++ | cut -c 2- | sed 's/^[ \t]*\(.*$\)/\1/') | ||
| echo "<xml>$DIFF</xml>" | xmlstarlet sel -t -m '//string' -v . -n > changed_texts.txt | ||
| TRANSLATIONS=$(cat changed_texts.txt) | ||
| TRANSLATIONS="${TRANSLATIONS//'%'/' ; '}" | ||
| TRANSLATIONS="${TRANSLATIONS//$'\n'/' ; '}" | ||
| TRANSLATIONS="${TRANSLATIONS//$'\r'/' ; '}" | ||
| echo $TRANSLATIONS |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be easier to use something like this?
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh that is indeed easier! I'll check it out, thanks!