Skip to content

Fix MRZ landscape crash #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix MRZ landscape crash #150

wants to merge 1 commit into from

Conversation

jlduragos
Copy link
Contributor

Issue

#144 MRZ reading in landscape crash

Changes

  1. Add missing element in landscape layout
  2. Ignore post block if viewFinder.display is null

megaxayda
megaxayda approved these changes Aug 26, 2023
View reviewed changes
Copy link
Collaborator

@megaxayda megaxayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@megaxayda megaxayda megaxayda approved these changes

@haklyray haklyray Awaiting requested review from haklyray

@jeremi jeremi Awaiting requested review from jeremi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jlduragos @megaxayda