Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(New):Nr 322277 media streaming #19620

Merged
merged 132 commits into from
Feb 25, 2025
Merged

Conversation

adutta-newrelic
Copy link
Contributor

@adutta-newrelic adutta-newrelic commented Jan 2, 2025

Work in Progress DO NOT MERGE

@adutta-newrelic adutta-newrelic self-assigned this Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Hi @adutta-newrelic 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 7ce7630
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/67bd6aa2d0ee1d0008928778
😎 Deploy Preview https://deploy-preview-19620--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adutta-newrelic adutta-newrelic added from_internal Identifies issues/PRs from Relics (except writers) from_tw Identifies issues/PRs from Tech Docs writers documentation labels Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

Copy link

github-actions bot commented Jan 2, 2025

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

Copy link

github-actions bot commented Jan 3, 2025

[!NOTE]

Our Vale automated writing feedback tool has suggestions for this PR. You can view these suggestions in the Files changed tab. If you're not a New Relic docs writer, we'll review any comments and you don't need to take any action (though feel free to make edits if you like!).

</tbody>
</table>

To understand which actions and attributes are captured and emitted by the Dash Player under different event types, see [Data dictionary]().
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To understand which actions and attributes are captured and emitted by the Dash Player under different event types, see [Data dictionary]().
To understand which actions and attributes are captured and emitted by the Dash Player under different event types, refer [Data dictionary]().

Copy link
Contributor

@vpayyapilly vpayyapilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talk to me

@adutta-newrelic adutta-newrelic marked this pull request as ready for review February 24, 2025 07:40
@adutta-newrelic adutta-newrelic dismissed vpayyapilly’s stale review February 25, 2025 04:58

Updated the changes as suggested by vinay

@sujitnewrelic sujitnewrelic self-requested a review February 25, 2025 08:48
Copy link
Contributor

@sujitnewrelic sujitnewrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbehera-newrelic cbehera-newrelic merged commit 636c8a7 into develop Feb 25, 2025
18 checks passed
@cbehera-newrelic cbehera-newrelic deleted the NR-322277-media-streaming branch February 25, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation from_internal Identifies issues/PRs from Relics (except writers) from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants