Skip to content

fix: obfuscate regexes #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: obfuscate regexes #2063

wants to merge 1 commit into from
+67 −20

Conversation

muruganishekar
Copy link
Contributor

  • fix obfuscation regex to allow special characters & special words

@muruganishekar muruganishekar requested a review from a team as a code owner May 21, 2025 15:31
@muruganishekar muruganishekar force-pushed the NR-413908 branch 2 times, most recently from 9fda6a1 to dfcb805 Compare May 21, 2025 15:51
@coveralls
Copy link

coveralls commented May 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15209770285

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 57.381%
Files with Coverage Reduction New Missed Lines %
pkg/config/config.go 2 70.63%
Totals Coverage Status
Change from base Build 15205587546: 0.01%
Covered Lines: 15401
Relevant Lines: 26840
💛 - Coveralls

@muruganishekar muruganishekar force-pushed the NR-413908 branch 4 times, most recently from fdab1f7 to 7e483a6 Compare May 21, 2025 16:22
ujwalsah
ujwalsah approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@ujwalsah ujwalsah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajrohanyadav
Copy link
Contributor

FWIW, I think @ is a very common char used in passwords. It should be improved if we can. I don't see any reason to not write a compliated regex if it gets the job done and we cover the edge cases with unittests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujwalsah ujwalsah ujwalsah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muruganishekar @coveralls @rajrohanyadav @ujwalsah