feat(alerts): add support for cci polling frequency field in conditions #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
=======================================
Coverage ? 36.85%
=======================================
Files ? 132
Lines ? 7808
Branches ? 0
=======================================
Hits ? 2878
Misses ? 4734
Partials ? 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
gffuentes
force-pushed
the
cci-polling-frequency
branch
2 times, most recently
from
4739360 to
47121b6
Compare
akane0915
reviewed
Jun 12, 2025
| AggregationDelay *int `json:"aggregationDelay"` | ||
| AggregationTimer *int `json:"aggregationTimer"` | ||
| SlideBy *int `json:"slideBy"` | ||
| PollingFrequency *int `json:"pollingFrequency,omitempty"` |
There was a problem hiding this comment.
PollingFrequency should be nullable, right? Curious if we should leave off omitEmpty here.
There was a problem hiding this comment.
PollingFrequency is only for static conditions, but alertsNrqlConditionBaselineCreate does allow for pollingFrequency: null.
There was a problem hiding this comment.
i fixed this - looks like create should allow null, but update should not
gffuentes
force-pushed
the
cci-polling-frequency
branch
from
47121b6 to
a06d530
Compare
gffuentes
force-pushed
the
cci-polling-frequency
branch
from
a06d530 to
02f8af5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET
https://new-relic.atlassian.net/browse/NR-413526
Adds support for polling frequency - a new field on conditions that is part of CCI project
newrelic/terraform-provider-newrelic#2890