Skip to content

Conversation

@jcrengifoa
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment on lines 449 to 455
const (
ThresholdSeveritySuccess ThresholdSeverity = "success"
ThresholdSeverityWarning ThresholdSeverity = "warning"
ThresholdSeveritySevere ThresholdSeverity = "severe"
ThresholdSeverityCritical ThresholdSeverity = "critical"
ThresholdSeverityUnavailable ThresholdSeverity = "unavailable"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our general practice is to keep any constants at the top of the file. We recommend using capital letters for constant strings, though you can use lowercase if your API requires it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it @shashank-reddy-nr, the variables have been moved + changed const in favor of var to further comply with the code standards

@shashank-reddy-nr shashank-reddy-nr changed the title feat: Add BillboardSettings and ThresholdWithSeriesOverrides to Dashboard Types feat: add BillboardSettings & ThresholdWithSeriesOverrides to Dashboard Jun 12, 2025
@jcrengifoa jcrengifoa marked this pull request as ready for review June 12, 2025 07:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.41%. Comparing base (91c26cb) to head (ba200fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
+ Coverage   35.36%   35.41%   +0.05%     
==========================================
  Files         130      130              
  Lines        7746     7746              
==========================================
+ Hits         2739     2743       +4     
+ Misses       4820     4818       -2     
+ Partials      187      185       -2     
Flag Coverage Δ
unit 35.41% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants