-
Notifications
You must be signed in to change notification settings - Fork 108
feat: add BillboardSettings & ThresholdWithSeriesOverrides to Dashboard #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add BillboardSettings & ThresholdWithSeriesOverrides to Dashboard #1305
Conversation
|
|
pkg/dashboards/dashboards_types.go
Outdated
| const ( | ||
| ThresholdSeveritySuccess ThresholdSeverity = "success" | ||
| ThresholdSeverityWarning ThresholdSeverity = "warning" | ||
| ThresholdSeveritySevere ThresholdSeverity = "severe" | ||
| ThresholdSeverityCritical ThresholdSeverity = "critical" | ||
| ThresholdSeverityUnavailable ThresholdSeverity = "unavailable" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our general practice is to keep any constants at the top of the file. We recommend using capital letters for constant strings, though you can use lowercase if your API requires it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it @shashank-reddy-nr, the variables have been moved + changed const in favor of var to further comply with the code standards
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
==========================================
+ Coverage 35.36% 35.41% +0.05%
==========================================
Files 130 130
Lines 7746 7746
==========================================
+ Hits 2739 2743 +4
+ Misses 4820 4818 -2
+ Partials 187 185 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.