Add w3c traceparent header support #1448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
- Coverage 80.33% 79.01% -1.33%
==========================================
Files 209 209
Lines 23709 23737 +28
Branches 3740 3745 +5
==========================================
- Hits 19047 18755 -292
- Misses 3437 3768 +331
+ Partials 1225 1214 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmstepanek
commented
Aug 18, 2025
hmstepanek
force-pushed
the
add-w3c-traceparent-header-support
branch
2 times, most recently
from
9df984c to
8a24ae6
Compare
hmstepanek
force-pushed
the
add-w3c-traceparent-header-support
branch
from
8a24ae6 to
bd981c4
Compare
hmstepanek
force-pushed
the
add-w3c-traceparent-header-support
branch
from
3be0999 to
971ede6
Compare
TimPansino
requested changes
Aug 20, 2025
Comment on lines
416
to
432
| @pytest.mark.parametrize( | ||
| "sampled,remote_parent_sampled,remote_parent_not_sampled,expected_sampled,expected_priority,expected_adaptive_sampling_algo_called", | ||
| ( | ||
| (True, 'default', 'default', None, None, True), # Uses sampling algo. | ||
| (True, 'always_on', 'default', True, 2, False), # Always sampled. | ||
| (True, 'always_off', 'default', False, 0, False), # Never sampled. | ||
| (False, 'default', 'default', None, None, True), # Uses sampling algo. | ||
| (False, 'always_on', 'default', None, None, True), # Uses sampling alog. | ||
| (False, 'always_off', 'default', None, None, True), # Uses sampling algo. | ||
| (True, 'default', 'always_on', None, None, True), # Uses sampling algo. | ||
| (True, 'default', 'always_off', None, None, True), # Uses sampling algo. | ||
| (False, 'default', 'always_on', True, 2, False), # Always sampled. | ||
| (False, 'default', 'always_off', False, 0, False), # Never sampled. | ||
| ) | ||
| ) | ||
| def test_distributed_trace_w3cparent_sampling_decision(sampled, remote_parent_sampled, remote_parent_not_sampled, expected_sampled, expected_priority, expected_adaptive_sampling_algo_called, wrap_sampling_algo_compute_sampled_and_priority): | ||
| required_intrinsics = [] |
There was a problem hiding this comment.
I feel like this should potentially be ported to the cross agent tests and standarized.
There was a problem hiding this comment.
That's a really good point! It doesn't look like we have any but I'll create a ticket for myself to add some-then maybe we can get rid of this one in leu of the cross agent test.
Comment on lines
464
to
475
| @pytest.fixture | ||
| def wrap_sampling_algo_compute_sampled_and_priority(): | ||
| global was_called | ||
| was_called = False | ||
|
|
||
| def _wrap_sampling_algo_compute_sampled_and_priority(wrapped, instance, args, kwargs): | ||
| global was_called | ||
| was_called = True | ||
| return wrapped(*args, **kwargs) | ||
|
|
||
| return _wrap_sampling_algo_compute_sampled_and_priority | ||
|
|
There was a problem hiding this comment.
The code here in this fixture and the code that's applying this as a wrapper should be a validator and go in the validators folder. This should be using a transient function wrapper that auto applies and unapplies this wrapping to the sampling_algo... function when the test runs.
There was a problem hiding this comment.
I think you're looking for validate_function_called
TimPansino
requested changes
Aug 26, 2025
| @@ -15,7 +15,7 @@ | |||
| import django | |||
| import pytest | |||
| import webtest | |||
| from testing_support.fixtures import function_not_called, override_generic_settings | |||
| from testing_support.validators.validate_function_not_called import validate_function_not_called, override_generic_settings | |||
There was a problem hiding this comment.
Suggested change
| from testing_support.validators.validate_function_not_called import validate_function_not_called, override_generic_settings | |
| from testing_support.fixtures import override_generic_settings | |
| from testing_support.validators.validate_function_not_called import validate_function_not_called |
Comment on lines
19
to
20
| from testing_support.fixtures import ( | ||
| function_not_called, | ||
| validate_function_not_called, |
There was a problem hiding this comment.
Suggested change
| from testing_support.fixtures import ( | |
| function_not_called, | |
| validate_function_not_called, | |
| from testing_support.fixture.validate_function_not_called import validate_function_not_called | |
| from testing_support.fixtures import ( |
…lic/newrelic-python-agent into add-w3c-traceparent-header-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for w3c traceparent sampled flag. See agent spec for details.