Feat: 토픽 조회(검색) 기능 구현 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Collaborator
caminobelllo
left a comment
caminobelllo
left a comment
There was a problem hiding this comment.
고생하셨습니다!
member 도메인에서 여러 인원이 작업해서 나중에 이 부분만 합칠 때 유의해주시면 될 것 같습니다.
Collaborator
There was a problem hiding this comment.
중복된 플로우 추출해 private로 캡슐화 하고, search / get / subscription만 퍼블릭으로 빼는 것도 좋을 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
넵 코드 리펙토링 할 때 참고하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 번호
close #15
✅ PR 전 확인!
💻 작업 내용
🖼️ 관련 스크린샷 (선택)
❗️Remark