Step3 경로조회 기능 #629
Open
owen-q wants to merge 3 commits into
Open
Conversation
|
hiblue02
requested changes
Jul 23, 2023
hiblue02
left a comment
hiblue02
left a comment
There was a problem hiding this comment.
3단계 미션도 빠르게 진행해주셨네요! 👍
코멘트 확인해주시고, 다시 리뷰 요청 주세요!
Comment on lines
+85
to
+89
| Assertions.assertThat(shortestPath.getDistance()).isEqualTo(16); | ||
| Assertions.assertThat(shortestPath.getStations().get(0)).isEqualTo(stationD); | ||
| Assertions.assertThat(shortestPath.getStations().get(1)).isEqualTo(stationA); | ||
| Assertions.assertThat(shortestPath.getStations().get(2)).isEqualTo(stationB); | ||
| Assertions.assertThat(shortestPath.getStations().get(3)).isEqualTo(stationC); |
There was a problem hiding this comment.
- assertThat 앞에 Assertions가 붙는데요, static import를 사용해보면 어떨까요?
- assertThat에서 리스트 내부 객체의 순서를 검증할 땐 containsExactly를 사용해면 어떨까요?
Comment on lines
+121
to
+127
| void 오류가발생한다() { | ||
| ExtractableResponse<Response> response = RestAssured.given().log().all() | ||
| .when().get(getPathUrl(stationC2.getId(), stationC2.getId())) | ||
| .then().log().all().extract(); | ||
|
|
||
| Assertions.assertThat(response.statusCode()).isEqualTo(HttpStatus.BAD_REQUEST.value()); | ||
| } |
Comment on lines
+6
to
+13
| @Configuration | ||
| public class ShortedPathFinderConfiguration { | ||
|
|
||
| @Bean | ||
| public ShortestPathFinder shortestPathFinder() { | ||
| return new DijkstraShortestPathFinder(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
step3 진행하였습니다~!