-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2단계 - 사다리(생성) #1601
Open
jimbaemon
wants to merge
12
commits into
next-step:jimbaemon
Choose a base branch
from
jimbaemon:step2
base: jimbaemon
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+464
−130
Open
2단계 - 사다리(생성) #1601
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
650c60d
docs: 기능 명세.
jimbaemon df26b5a
feat: 참여자의 이름은 5자를 넘지 않는다.
jimbaemon 5042230
feat: 이전 값을 조회하여 라인이 있다면 라인은 만들지 않는다.
jimbaemon a08e9c3
docs: 기능 재명세.
jimbaemon ddf92f0
feat: 라인들은 인원수 -1 만큼 존재한다.
jimbaemon 76e6b3a
feat: 라인을 랜덤으로 설정한다.
jimbaemon 769a9ce
feat: 사용자가 입력한 만큼 사다리의 층을 만든다.
jimbaemon 581332a
feat: View 를 위한 출력문 생성.
jimbaemon 49aa28c
feat: 연결.
jimbaemon 294206f
style: 사다리 간격 조정.
jimbaemon 38370f1
refactor: 컨벤션 정리.
jimbaemon a43e229
refactor: Magic Int 상수 처리.
jimbaemon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: 컨벤션 정리.
commit 38370f1944168fb75cd9f490bf800ba1cf4e28a6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,39 +1,39 @@ | ||
package nextstep.optional; | ||
|
||
public class Computer { | ||
private Soundcard soundcard; | ||
private Soundcard soundcard; | ||
|
||
public Computer(Soundcard soundcard) { | ||
this.soundcard = soundcard; | ||
} | ||
public Computer(Soundcard soundcard) { | ||
this.soundcard = soundcard; | ||
} | ||
|
||
public Soundcard getSoundcard() { | ||
return soundcard; | ||
} | ||
public Soundcard getSoundcard() { | ||
return soundcard; | ||
} | ||
|
||
public static class Soundcard { | ||
private USB usb; | ||
public static class Soundcard { | ||
private USB usb; | ||
|
||
public Soundcard(USB usb) { | ||
super(); | ||
this.usb = usb; | ||
} | ||
public Soundcard(USB usb) { | ||
super(); | ||
this.usb = usb; | ||
} | ||
|
||
public USB getUsb() { | ||
return usb; | ||
} | ||
} | ||
public USB getUsb() { | ||
return usb; | ||
} | ||
} | ||
|
||
public static class USB { | ||
private String version; | ||
public static class USB { | ||
private String version; | ||
|
||
public USB(String version) { | ||
super(); | ||
this.version = version; | ||
} | ||
public USB(String version) { | ||
super(); | ||
this.version = version; | ||
} | ||
|
||
public String getVersion() { | ||
return this.version; | ||
} | ||
} | ||
public String getVersion() { | ||
return this.version; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toString을 올바르게 사용한다면 현재 Players 일급컬렉션은 큰 의미를 가지기가 어려울 것 같아요!!