Step4 #6065
Merged
Step4 #6065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskangg
requested changes
Mar 21, 2025
Comment on lines
7
to
8
| private String[] carNames; | ||
| private int maxCarPosition; |
There was a problem hiding this comment.
RacingCarView는 입출력을 담당하는 역할인데, 내부적으로 자동차 이름들과 최대 위치 값을 필드로 갖고 있네요 🤔
보통 View 클래스는 출력 형식 정의나 사용자 입력 처리를 주된 역할로 가져야 하고, 게임의 상태나 데이터를 직접 저장하는 것은 지양하는 것이 좋습니다.
RacingCarView는 단순히 게임 상태를 화면에 출력하는 역할만 담당하도록 하고,
자동차의 상태(이름, 위치 등)는 별도의 객체(RacingCar)에 저장하는 것이 더 적절합니다.
그리고 최대 위치 값은 우승자를 구하는 비즈니스를 가진 객체에게 할당하는 건 어떨까요?
Comment on lines
56
to
60
| for (int i = 0; i < this.carNum; i++) { | ||
| if (cars[i].position() == this.maxCarPosition) { | ||
| winnerJoiner.add(cars[i].name()); | ||
| } | ||
| } |
There was a problem hiding this comment.
출력을 담당하는 View 클래스가 우승자를 정하고 있군요 🤔
여기선 우승자를 전달받아 출력만하고 우승자를 구하는 도메인 객체가 필요해보여요.
mskangg
approved these changes
Mar 23, 2025
| ## 요구사항 | ||
| - [x] 자동차의 이름을 입력 받는다. | ||
| - [] 우승자를 구한다. |
Comment on lines
+15
to
+21
| void findWinners(int maxCarPosition) { | ||
| for (RacingCar car : cars) { | ||
| if (maxCarPosition == car.position()) { | ||
| this.winningCars.add(car); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| void findWinners(int maxCarPosition) { | |
| for (RacingCar car : cars) { | |
| if (maxCarPosition == car.position()) { | |
| this.winningCars.add(car); | |
| } | |
| } | |
| } | |
| RacingCar[] findWinners(int maxCarPosition) { | |
| for (RacingCar car : cars) { | |
| if (maxCarPosition == car.position()) { | |
| this.winningCars.add(car); | |
| } | |
| } | |
| return winningCars.toArray(new RacingCar[winningCars.size()]); | |
| } |
메서드명이 find 이니 winners 를 찾아서 리턴해주는방향은 어떨까요?
조금더 직관적일것 같아요 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰 요청드립니다.
결과화면
