Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step3 구현 #6069
Step3 구현 #6069
Changes from 4 commits
3251ff1
6cef38f
7956ae6
351ce87
b02bfce
8869128
b9ec1db
f9ca171
f1b69c3
98fda6f
0fb2064
6f367dc
a59eb0e
4065de4
bd07d90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
랜덤값으로 인하여, 테스트가 용이하지 않죠.
이런 경우 interface를 통해 확장성을 고려해볼수 있습니다.
https://tecoble.techcourse.co.kr/post/2020-05-17-appropriate_method_for_test_by_interface/
위 글을 참고해서 한번 적용해보시면 테스트 코드 작성이 어렵지 않지 않을까 생각이들어요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
붙혀주신 링크 확인하였습니다! 해당 링크에 있는 방법대로 구현하기 전에 질문드리고 싶은것이 있는데요,
NumberGenerator 관련하여, MovableNumberGenerator의 경우 test만을 위해 새롭게 구현하는 class로 보여지는데, (제가 TDD에 대해 잘 몰라서) 이렇게 test만을 위해 class를 추가하는 것이 전체 코드의 복잡도를 오히려 올리는 것이 아닌지 하는 생각이 들어 의견 여쭤보고 싶습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트 폴더에 넣는다면 응집도 관점에서 맞지 않을까요~?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interface 방식으로 refactor 하고, 테스트코드 추가하였습니다~!