Step5 #6076
Open
Step5 #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared-moon
requested changes
Mar 21, 2025
| this.cars = List.copyOf(cars); | ||
| } | ||
|
|
||
| public static Cars fromNames(List<String> names) { |
| return new Cars(cars); | ||
| } | ||
|
|
||
| public Cars withAddedCar(Car car) { |
| return Collections.unmodifiableList(cars); | ||
| } | ||
|
|
||
| public List<String> getWinners(Cars records) { |
| public List<String> getWinners(Cars records) { | ||
| int maxPosition = getMaxPosition(records); | ||
| return records.stream() | ||
| .filter(car -> car.getPosition() == maxPosition) |
There was a problem hiding this comment.
Car.equalsPosition 을 만들어서 getter 대신 질의를 던져보는건 어떨까요 ?
| @DisplayName("우승자가 한 명이면 한 명의 이름을 반환한다.") | ||
| void getWinnerOne() { | ||
| Cars cars = new Cars(new ArrayList<>()); | ||
| cars = cars.withAddedCar(new Car("pobi", 2)); |
There was a problem hiding this comment.
getWinners 테스트를 위해 사전조건 세팅을 하려고 메서드를 추가하신 것 같아요 ~
getWinners 내에서 Car의 동작을 제어하지 못해서 이렇게 진행하신걸로 이해가 되는데 mockito를 이용해서 Car를 목킹하여 응답값을 제어해보면 어떨까요 ?
위에도 적어뒀지만, 테스트를 위한 메서드 생성은 지양하는게 좋아서요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.