5단계 - 자동차 경주(리팩토링) #6079
Merged
5단계 - 자동차 경주(리팩토링) #6079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pci2676
approved these changes
Mar 22, 2025
Comment on lines
+6
to
+25
| public class Winners { | ||
| public static List<String> findWinners(List<GameRound> cars) { | ||
| List<Car> finalRound = cars.get(cars.size() - 1).getRound(); | ||
| return filterWinners(finalRound, findMaxPosition(finalRound)); | ||
| } | ||
|
|
||
| private static List<String> filterWinners(List<Car> cars, int maxPosition) { | ||
| return cars.stream() | ||
| .filter(car -> car.isSamePosition(maxPosition)) | ||
| .map(Car::getName) | ||
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| private static int findMaxPosition(List<Car> cars) { | ||
| int maxPosition = 0; | ||
| for (Car car : cars) { | ||
| maxPosition = car.max(maxPosition); | ||
| } | ||
| return maxPosition; | ||
| } |
There was a problem hiding this comment.
Winner가 GameRound를 다루는 static한 함수만 가지고 있을게 아니라
일급컬렉션으로 설계해보면 더 좋을것 같습니다. :)
Comment on lines
+17
to
+19
| for (GameRound round : result) { | ||
| for (Car car : round.getRound()) { | ||
| System.out.println(car.getName() + " : " + "-".repeat(car.getPosition())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요. get 함수를 줄이려고 해봤는데 생각보다 쉽지 않네요.,,
항상 꼼꼼한 리뷰해주셔서 감사합니다 🙇♂️🥹