Skip to content

fix(qwik): don't build server deps on client #12723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2025

Conversation

wmertens
Copy link
Contributor

@wmertens wmertens commented Mar 3, 2025

☕️ Reasoning

Put some isServer guards so @auth/core is not bundled for the client, since that breaks the build with Vite 6.

The culprit is the environment configuration.

🧢 Checklist

  • Ready to be merged

🎫 Affected issues

none created

📌 Resources

@wmertens wmertens requested a review from ThangHuuVu as a code owner March 3, 2025 21:47
Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 3:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 10, 2025 3:23am

Copy link

vercel bot commented Mar 3, 2025

@wmertens is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@wmertens
Copy link
Contributor Author

wmertens commented Mar 7, 2025

Any chance of a review? It's a small change and it prevents people from using @authjs/qwik with vite 6

@wmertens
Copy link
Contributor Author

This is blocking QwikDev/qwik#7382

@thejackshelton
Copy link

thejackshelton commented Mar 22, 2025

@ThangHuuVu @balazsorban44 if you have a couple of minutes to review 🙏 . Ideally we'd like to upgrade to vite 6, but we want to make sure those using auth js continue to have a seamless experience 🙂

@Nefcanto
Copy link

Nefcanto commented Apr 6, 2025

@thejackshelton, thank you for following up. Since Vite is the foundation for many projects, can you please follow this PR again to speed up its merging?

The optimizer doesn't fully remove server imports and it helps to put `isServer` guards so server-side modules are not bundled for the client
@wmertens
Copy link
Contributor Author

wmertens commented May 6, 2025

@ThangHuuVu is there any chance of you hitting the approve button so the workflow can run?

Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for the delay, I'll cut a release this weekend.

Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.19%. Comparing base (4155eee) to head (a6112bb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12723   +/-   ##
=======================================
  Coverage   39.19%   39.19%           
=======================================
  Files         200      200           
  Lines       31606    31606           
  Branches     1374     1380    +6     
=======================================
  Hits        12388    12388           
  Misses      19218    19218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ThangHuuVu ThangHuuVu merged commit 9f09e30 into nextauthjs:main May 10, 2025
13 of 15 checks passed
@Nefcanto
Copy link

Thank you guys. Special thanks to @wmertens. Our team migrated to Vite 6 without a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants