Feature - Check Auto Upload Sub Folder by alperozturk96 · Pull Request #14547 · nextcloud/android

alperozturk96 · 2025-02-13T15:53:28Z

Tests written, or not not needed

tobiasKaminsky · 2025-03-05T08:50:02Z

as discussed

do not automatically change it
show an info it auto upload overview

alperozturk96 · 2025-03-05T13:14:48Z

Info image button added to the auto upload page. @ZetaTom @tobiasKaminsky Please review

fff.mp4

jancborchardt

In both cases where it appears – but especially when clicking the info "i" icon – it would be more fitting to use a modal since the info is more important than to just show it in a toast.

alperozturk96 · 2025-03-12T09:11:16Z

+        if (titleIconId == defaultTitleIconId) {
+            builder
+                .setIcon(titleIconId)
+                .setIconAttribute(R.attr.alertDialogIcon)


Only setIconAttribute for defaultTitleIconId otherwise it will override given titleIconId

jancborchardt

Thanks for the adjustments @alperozturk96! :)

Signed-off-by: alperozturk <alper_ozturk@proton.me>

…isplayItem> Signed-off-by: alperozturk <alper_ozturk@proton.me>

Signed-off-by: alperozturk <alper_ozturk@proton.me>

github-actions · 2025-03-31T07:36:26Z

Codacy

Lint

Type	master	PR
Warnings	54	54
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	58
Dodgy code	292	292
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	51	51
Security	18	18
Total	500	500

github-actions · 2025-03-31T07:36:34Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14547.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

carlhaupt · 2025-09-17T21:55:43Z

its back again with version 3.33.0 of android com.nextcloud.client. I cannot use the camera-folder from actual camera aperture only because I have opencamera and others which store in DCIM. and it says there will be doublettes because there is an upload which saves /camera alread als subfolder, but I cannot see the definition of the main /DCIM-Folder which is mentioned. There are 2 or even more definitions of subfolders with the same path, which i can hide but do all the same. /download/DCIMALT for example from a former backup of the old phone is twice in the list, the same with others. And no delete-Button for those, just hide-option, in my case 6 or 7 hidden folders already,

I haven't tried to reset the client to get rid of those, cause chatgpt thought its the best to inform you this way that the bug is back again

plz fix again. thanks

alperozturk96 added the 2. developing label Feb 13, 2025

alperozturk96 linked an issue Feb 13, 2025 that may be closed by this pull request

Enhancing Auto-Upload Functionality: Preventing Redundant Sub-Folder Uploads #14462

Closed

alperozturk96 force-pushed the feature/check-auto-upload-sub-folder branch 2 times, most recently from 2bb8991 to 3bc227d Compare February 18, 2025 12:31

alperozturk96 added 3. to review and removed 2. developing labels Feb 18, 2025

alperozturk96 requested review from ZetaTom and tobiasKaminsky February 18, 2025 13:02

alperozturk96 force-pushed the feature/check-auto-upload-sub-folder branch 2 times, most recently from 96caffc to ff29eb2 Compare February 21, 2025 10:36

alperozturk96 force-pushed the feature/check-auto-upload-sub-folder branch 2 times, most recently from 2d57ed3 to 0b2f161 Compare March 4, 2025 14:20

alperozturk96 force-pushed the feature/check-auto-upload-sub-folder branch from 0b2f161 to f68d67b Compare March 5, 2025 12:28

alperozturk96 requested a review from jancborchardt March 7, 2025 08:34

jancborchardt requested changes Mar 10, 2025

View reviewed changes

alperozturk96 force-pushed the feature/check-auto-upload-sub-folder branch 2 times, most recently from 2a713f7 to c0130f9 Compare March 11, 2025 09:20

alperozturk96 requested a review from jancborchardt March 11, 2025 09:21

alperozturk96 force-pushed the feature/check-auto-upload-sub-folder branch from c0130f9 to 9d0783e Compare March 12, 2025 08:29

alperozturk96 commented Mar 12, 2025

View reviewed changes

jancborchardt approved these changes Mar 13, 2025

View reviewed changes

alperozturk96 mentioned this pull request Mar 14, 2025

Enhancing Auto-Upload Functionality: Preventing Redundant Sub-Folder Uploads #14462

Closed

tobiasKaminsky approved these changes Mar 19, 2025

View reviewed changes

alperozturk96 force-pushed the feature/check-auto-upload-sub-folder branch from 55b01f9 to 6b78844 Compare March 19, 2025 11:13

alperozturk96 added 2. developing and removed 3. to review labels Mar 19, 2025

alperozturk96 marked this pull request as draft March 19, 2025 11:30

alperozturk96 marked this pull request as ready for review March 19, 2025 14:11

joshtrichards removed a link to an issue Mar 29, 2025

Enhancing Auto-Upload Functionality: Preventing Redundant Sub-Folder Uploads #14462

Closed

joshtrichards linked an issue Mar 29, 2025 that may be closed by this pull request

Auto-upload on Android-client should prevent (recursive) uploading of Android-app-files #8503

Closed

alperozturk96 added 21 commits March 31, 2025 09:27

use lifecycleScope

ec5aa9e

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add getEnabledOrWithoutEnabledParent extension for List<SyncedFolderD…

f1da19e

…isplayItem> Signed-off-by: alperozturk <alper_ozturk@proton.me>

use extension

fca8321

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add removeAutoUploadFromSubFoldersWithEnabledParent

81c6e09

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add documentations to the functions and use better function names

a5d2ca1

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add documentations to the functions and use better function names

d387442

Signed-off-by: alperozturk <alper_ozturk@proton.me>

check isGivenLocalPathHasEnabledParent

66ad7f2

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add tests

e82f8dc

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add missing import

a862c14

Signed-off-by: alperozturk <alper_ozturk@proton.me>

inform user and remove auto delete

aa69adf

Signed-off-by: alperozturk <alper_ozturk@proton.me>

rename imagebutton

7161742

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix code analytics

f1e59bf

Signed-off-by: alperozturk <alper_ozturk@proton.me>

show alert dialog instead of snackbar

8b9a438

Signed-off-by: alperozturk <alper_ozturk@proton.me>

change title, title icon and positive button text

8a507d9

Signed-off-by: alperozturk <alper_ozturk@proton.me>

add tint for title icon

754c4a7

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix code analytics

291019a

Signed-off-by: alperozturk <alper_ozturk@proton.me>

change positiveButtonTextId for overview page

95f4770

Signed-off-by: alperozturk <alper_ozturk@proton.me>

check parents recursively to determine sub folder of sub folders

9f397f5

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fixes

8d8eec1

Signed-off-by: alperozturk <alper_ozturk@proton.me>

remove test due to file existance check

188858a

Signed-off-by: alperozturk <alper_ozturk@proton.me>

fix code analytics

b6be668

Signed-off-by: alperozturk <alper_ozturk@proton.me>

alperozturk96 force-pushed the feature/check-auto-upload-sub-folder branch from e31d1c2 to b6be668 Compare March 31, 2025 07:27

tobiasKaminsky approved these changes Apr 2, 2025

View reviewed changes

tobiasKaminsky merged commit 8b323a2 into master Apr 2, 2025

tobiasKaminsky deleted the feature/check-auto-upload-sub-folder branch April 2, 2025 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Feature - Check Auto Upload Sub Folder - #14547

Feature - Check Auto Upload Sub Folder#14547
tobiasKaminsky merged 21 commits into
masterfrom
feature/check-auto-upload-sub-folder

alperozturk96 commented Feb 13, 2025 •

edited

Loading

Uh oh!

tobiasKaminsky commented Mar 5, 2025

Uh oh!

alperozturk96 commented Mar 5, 2025

Uh oh!

jancborchardt left a comment

Uh oh!

alperozturk96 Mar 12, 2025

Uh oh!

jancborchardt left a comment

Uh oh!

github-actions Bot commented Mar 31, 2025

Uh oh!

github-actions Bot commented Mar 31, 2025

Uh oh!

carlhaupt commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

alperozturk96 commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasKaminsky commented Mar 5, 2025

Uh oh!

alperozturk96 commented Mar 5, 2025

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

alperozturk96 Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 31, 2025

Codacy

Lint

SpotBugs

Uh oh!

github-actions Bot commented Mar 31, 2025

Uh oh!

carlhaupt commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alperozturk96 commented Feb 13, 2025 •

edited

Loading