made functions void where their return values were never used

[alexknop]

Problem:
There were functions that were declared to return values, but when used in the project, there was no use of the return values.

Solution:
Change these functions to void for now.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[tobiasKaminsky]

Thanks for your PR 🎉
Can you check and fix Spotbugs?

[alexknop]

Thanks for your PR 🎉 Can you check and fix Spotbugs?

Could use help in how to check that...
I'm seeing some in the Analysis tab of the Checks, but not sure what is related to this branch...as in what would have increased.

[tobiasKaminsky]

Spotbugs has +1 issue.
Best is two open both html files side by side and check for diff.
Unfortunately there is no other easy way.

DB: Duplicate Branches (1: 0/1/0/0)
Method uses the same code for two branches   (1: 0/1/0/0)
 In class com.owncloud.android.datamodel.UploadsStorageManager
In method com.owncloud.android.datamodel.UploadsStorageManager.updateDatabaseUploadResult(RemoteOperationResult, UploadFileOperation)
At UploadsStorageManager.java:[line 802]
At UploadsStorageManager.java:[line 805]
com.owncloud.android.datamodel.UploadsStorageManager.updateDatabaseUploadResult(RemoteOperationResult, UploadFileOperation) uses the same code for two branches

So it seems that your change made then / else branch to be the same, thus not needed at all.

[alexknop]

Spotbugs has +1 issue. Best is two open both html files side by side and check for diff. Unfortunately there is no other easy way.

DB: Duplicate Branches (1: 0/1/0/0)
Method uses the same code for two branches   (1: 0/1/0/0)
 In class com.owncloud.android.datamodel.UploadsStorageManager
In method com.owncloud.android.datamodel.UploadsStorageManager.updateDatabaseUploadResult(RemoteOperationResult, UploadFileOperation)
At UploadsStorageManager.java:[line 802]
At UploadsStorageManager.java:[line 805]
com.owncloud.android.datamodel.UploadsStorageManager.updateDatabaseUploadResult(RemoteOperationResult, UploadFileOperation) uses the same code for two branches

So it seems that your change made then / else branch to be the same, thus not needed at all.

Fixed!

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14582.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.