Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assistant Screen UI Improvements #14675

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Assistant Screen UI Improvements #14675

wants to merge 9 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 14, 2025 •
edited
Loading

  • Tests written, or not not needed

Task List

Before Dark ModeImage 1 After Dark ModeImage 2 After Light ModeImage 3

Task Detail

Before Dark ModeImage 1 After Dark ModeImage 2 After Light ModeImage 3

Empty Task List

After Dark ModeImage 2 After Light ModeImage 3

@alperozturk96 alperozturk96 linked an issue Mar 14, 2025 that may be closed by this pull request
[Assistant_Android] Improve Assistant on mobile screen #14145
Open
6 tasks
@alperozturk96 alperozturk96 mentioned this pull request Mar 14, 2025
Open
6 tasks
@nextcloud nextcloud deleted a comment from github-actions bot Mar 14, 2025
jancborchardt
jancborchardt requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"After Dark Mode" in "Task Detail" still seems like it’s incorrect, shouldn’t it be darker input fields instead? Otherwise it looks good! :)

@alperozturk96 alperozturk96 force-pushed the assistant-screen-ui-improvements branch from f079d95 to 0dfb1bc Compare March 18, 2025 08:33
jancborchardt
jancborchardt approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thank you! :)

@alperozturk96 alperozturk96 force-pushed the assistant-screen-ui-improvements branch from 2a3064b to 5680697 Compare March 20, 2025 08:09
@alperozturk96
update ss
628878c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
reduce lint
cc9de71 
Signed-off-by: alperozturk <[email protected]>
@nextcloud nextcloud deleted a comment from github-actions bot Mar 20, 2025
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14675.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Assistant_Android] Improve Assistant on mobile screen
2 participants
@alperozturk96 @jancborchardt