Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Version Catalog #14713

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Mar 20, 2025

  • Tests written, or not not needed

Migrate your build to version catalogs

Gradle version catalogs

Given the numerous dependencies, I propose initiating the migration process in this PR. Over time, we can progressively transition all dependencies to the TOML file.

@alperozturk96
Copy link
Collaborator Author

@AndyScherzinger How can we fix REUSE Compliance Check in TOML file?

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 21, 2025

@AndyScherzinger How can we fix REUSE Compliance Check in TOML file?

@alperozturk96 see

https://github.com/nextcloud/android/blob/master/REUSE.toml#L1-L2

But with 2025 in your case. If that doesn't work (it should since it is a valid toml comment), add a .toml.license with the above header (no #) as content next to the toml file.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the migrate-to-version-catalog branch from 16940f2 to 029250d Compare March 21, 2025 10:17
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code292292
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total500500

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14713.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me as long as it is ensured that renovate bot can still detect it and send update PRs

@tobiasKaminsky tobiasKaminsky merged commit 034a2ed into master Apr 2, 2025
20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the migrate-to-version-catalog branch April 2, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants