Skip to content

fix: Migrate getById to getFirstNodeById#211

Merged
artonge merged 1 commit intomainfrom
artonge/fix/getbyid
Feb 3, 2026
Merged

fix: Migrate getById to getFirstNodeById#211
artonge merged 1 commit intomainfrom
artonge/fix/getbyid

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Feb 3, 2026

No description provided.

@artonge artonge force-pushed the artonge/fix/getbyid branch from 39a5780 to a2b2cc5 Compare February 3, 2026 10:51
@kyteinsky
Copy link
Contributor

this too please :)

$node = current($this->rootFolder->getUserFolder($fsEvent->getUserId())->getById($fsEvent->getNodeId()));

@artonge artonge force-pushed the artonge/fix/getbyid branch from a2b2cc5 to 7b3206e Compare February 3, 2026 11:14
@artonge artonge force-pushed the artonge/fix/getbyid branch from 7b3206e to a268e5c Compare February 3, 2026 11:14
@artonge
Copy link
Contributor Author

artonge commented Feb 3, 2026

/backport to stable33

@kyteinsky
Copy link
Contributor

should be backported to stable31, we support multiple server versions per stable release of this app.
but NC 31 is going EOL this month 🤷

@artonge
Copy link
Contributor Author

artonge commented Feb 3, 2026

should be backported to stable31, we support multiple server versions per stable release of this app.
but NC 31 is going EOL this month 🤷

I just want the fix in 33, 32 and 31 were not that much of an issue.

@kyteinsky
Copy link
Contributor

cool, no backport is required then, NC 32 and 33 are released from the main branch

@artonge artonge requested a review from marcelklehr February 3, 2026 11:31
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@artonge artonge merged commit 6f1e0a9 into main Feb 3, 2026
36 checks passed
@artonge artonge deleted the artonge/fix/getbyid branch February 3, 2026 13:05
@kyteinsky kyteinsky mentioned this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants