-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS Session Token configuration #2364
base: master
Are you sure you want to change the base?
Add support for AWS Session Token configuration #2364
Conversation
Thanks, @refucktor. Will take a closer look when the upstream support is added. May also require some special handling if the upstream support is considered a feature and doesn't get backported to all of the major versions we support. One bit of immediate feedback: this PR needs docs (entry in the appropriate section of the repo README). P.S. Ping this PR one of us doesn't get around to re-looking at this PR after upstream is merged. |
- Introduced logic to handle S3 session token using environment variables. - Supports session token from both a file and direct environment variable. - Defaults to an empty token if no value is provided. Signed-off-by: Hector Valcarcel <[email protected]>
- variable "OBJECTSTORE_S3_SESSION_TOKEN" to support AWS STS auth workflow Signed-off-by: Hector Valcarcel <[email protected]>
7928e7a
to
ecbd2ab
Compare
hey @joshtrichards I received a notification that the PR in the 'server' repo has been merged. I guess we are getting closer to merge this one |
Indeed. Looks like it'll be in v32 (since it's a new feature). I'm still not sure how to best handle the We could just document the variable as >=v32 only.... or we could enhance @J0WI Thoughts? |
Summary