-
Notifications
You must be signed in to change notification settings - Fork 2.1k
refactor(admin): Improve the PHP Modules & Configuration chapter #13573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Josh Richards <[email protected]>
Signed-off-by: Josh Richards <[email protected]>
Aside: I tapped GitHub Copilot to suggest an initial improvement baseline for rewriting this section. I was able to turn around a nice prototype in seconds. I disagreed with some of the changes so it took a couple more hours to make things how I wanted (through good old-fashioned manual editing). Based on this experiment, Copilot (or other similar AI agents) can be a helpful tool for refactoring our documentation. |
Signed-off-by: Josh <[email protected]>
+------------------+----------+-------------+------------------+-----------------------------------------------+ | ||
| imagick | | | ✓ (optional) | Image previews | | ||
+------------------+----------+-------------+------------------+-----------------------------------------------+ | ||
| avconv/ffmpeg | | | ✓ (optional) | Video previews | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit misleading, as avconf/ffmpeg/libreoffice are no PHP modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, but that's somewhat of a problem already on this page as-is. ;-) I'm thinking of adding a "Preparing your Server" (or similar) chapter as part of a broader reorg of the entire Installation/Deployment section. Those might better belong somewhere like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
@joshtrichards I’m afraid this might break https://github.com/nextcloud/documentation/blob/f8048dafcba898cbbc973966b61657378ba5d08e/go.php#L38C1-L39C1 ? |
Signed-off-by: Josh Richards <[email protected]>
@come-nc Good catch. Fixed. |
☑️ Resolves
The current chapter covering how to prepare PHP for a new Nextcloud Server installation is fairly comprehensive, but I felt could benefit from some polishing.
Improved by (among other things):
I think the chapter's clarity has improved. And the new headings also make it easier to link to specific scenarios.
P.S. While doing this I noted that there was initially a commit in #12871 that elaborated on
gmp
for WebAuthn but it got chopped during a merge ofmaster
back into that PR. Was that intentional or an accident? Cc: @susnux & @rakekniven🖼️ Screenshots
New
Previously: