Skip to content

Commit

Permalink
Fix(psalm): Update psalm baseline and fix undefined magic methods
Browse files Browse the repository at this point in the history 
Signed-off-by: Christian Hartmann <[email protected]>
  • Loading branch information
@Chartman123
Chartman123 committed Feb 14, 2025
1 parent 26be6f8 commit fca8a17
Showing 1 changed file with 13 additions and 214 deletions.
227 changes: 13 additions & 214 deletions tests/psalm-baseline.xml
View file
Original file line number Diff line number Diff line change
@@ -1,247 +1,46 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.8.0@9cf4f60a333f779ad3bc704a555920e81d4fdcda">
<file src="lib/Activity/Provider.php">
<InvalidCatch>
<code><![CDATA[try {
// Overwrite formTitle if form is found (i.e. still exists).
$formTitle = $this->formMapper->findbyHash($formHash)->getTitle();
// Append hash and route
$formLink .= $formHash;
if ($route !== '') {
$formLink .= '/' . $route;
}
} catch (IMapperException $e) {
// Ignore if not found, just use stored title
}]]></code>
</InvalidCatch>
</file>
<file src="lib/AppInfo/Application.php">
<InvalidArgument>
<code>UserDeletedListener::class</code>
</InvalidArgument>
</file>
<files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
<file src="lib/Controller/ApiController.php">
<InvalidCatch>
<code><![CDATA[try {
$questions[$arrayKey] = $this->questionMapper->findById($questionId);
} catch (IMapperException $e) {
$this->logger->debug('Could not find question. Id:{id}', [
'id' => $questionId
]);
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findByHash($hash);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findByHash($hash);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findByHash($hash);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findByHash($hash);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findById($formId);
$questions = $this->formsService->getQuestions($formId);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findById($formId);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findById($formId);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findById($formId);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findById($id);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formMapper->findById($id);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$form = $this->formsService->getForm($id);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$oldForm = $this->formMapper->findById($id);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form');
throw new OCSBadRequestException();
}]]></code>
<code><![CDATA[try {
$option = $this->optionMapper->findById($id);
$question = $this->questionMapper->findById($option->getQuestionId());
$form = $this->formMapper->findById($question->getFormId());
} catch (IMapperException $e) {
$this->logger->debug('Could not find form or option');
throw new OCSBadRequestException('Could not find form or option');
}]]></code>
<code><![CDATA[try {
$option = $this->optionMapper->findById($id);
$question = $this->questionMapper->findById($option->getQuestionId());
$form = $this->formMapper->findById($question->getFormId());
} catch (IMapperException $e) {
$this->logger->debug('Could not find option, question or form');
throw new OCSBadRequestException('Could not find option, question or form');
}]]></code>
<code><![CDATA[try {
$question = $this->questionMapper->findById($id);
$form = $this->formMapper->findById($question->getFormId());
} catch (IMapperException $e) {
$this->logger->debug('Could not find form or question');
throw new OCSBadRequestException('Could not find form or question');
}]]></code>
<code><![CDATA[try {
$question = $this->questionMapper->findById($id);
$form = $this->formMapper->findById($question->getFormId());
} catch (IMapperException $e) {
$this->logger->debug('Could not find form or question');
throw new OCSBadRequestException('Could not find form or question');
}]]></code>
<code><![CDATA[try {
$question = $this->questionMapper->findById($questionId);
$form = $this->formMapper->findById($question->getFormId());
} catch (IMapperException $e) {
$this->logger->debug('Could not find form or question');
throw new OCSBadRequestException('Could not find form or question');
}]]></code>
<code><![CDATA[try {
$submission = $this->submissionMapper->findById($id);
$form = $this->formMapper->findById($submission->getFormId());
} catch (IMapperException $e) {
$this->logger->debug('Could not find form or submission');
throw new OCSBadRequestException();
}]]></code>
</InvalidCatch>
</file>
<file src="lib/Controller/ShareApiController.php">
<InvalidCatch>
<code><![CDATA[try {
$form = $this->formMapper->findById($formId);
} catch (IMapperException $e) {
$this->logger->debug('Could not find form', ['exception' => $e]);
throw new OCSBadRequestException('Could not find form');
}]]></code>
<code><![CDATA[try {
$share = $this->shareMapper->findById($id);
$form = $this->formMapper->findById($share->getFormId());
} catch (IMapperException $e) {
$this->logger->debug('Could not find share', ['exception' => $e]);
throw new OCSBadRequestException('Could not find share');
}]]></code>
<code><![CDATA[try {
$share = $this->shareMapper->findById($id);
$form = $this->formMapper->findById($share->getFormId());
} catch (IMapperException $e) {
$this->logger->debug('Could not find share', ['exception' => $e]);
throw new OCSBadRequestException('Could not find share');
}]]></code>
</InvalidCatch>
<RedundantCondition>
<code><![CDATA[method_exists($this->mimeTypeDetector, 'getAllMappings')]]></code>
</RedundantCondition>
</file>
<file src="lib/Db/Form.php">
<UndefinedMagicMethod>
<code>getAccessEnum</code>
<code>setAccessEnum</code>
<code><![CDATA[getAccessEnum]]></code>
<code><![CDATA[setAccessEnum]]></code>
</UndefinedMagicMethod>
</file>
<file src="lib/Db/Question.php">
<UndefinedMagicMethod>
<code>getExtraSettingsJson</code>
<code>setExtraSettingsJson</code>
<code><![CDATA[getExtraSettingsJson]]></code>
<code><![CDATA[setExtraSettingsJson]]></code>
</UndefinedMagicMethod>
</file>
<file src="lib/Db/Share.php">
<UndefinedMagicMethod>
<code>getPermissionsJson</code>
<code>setPermissionsJson</code>
<code><![CDATA[getPermissionsJson]]></code>
<code><![CDATA[setPermissionsJson]]></code>
</UndefinedMagicMethod>
</file>
<file src="lib/FormsMigrator.php">
<UndefinedClass>
<code>OutputInterface</code>
<code>OutputInterface</code>
</UndefinedClass>
</file>
<file src="lib/Middleware/PublicCorsMiddleware.php">
<NoInterfaceProperties>
<code><![CDATA[$this->request->server]]></code>
</NoInterfaceProperties>
<UndefinedClass>
<code>SecurityException</code>
<code>SecurityException</code>
</UndefinedClass>
<UndefinedDocblockClass>
<code>SecurityException</code>
</UndefinedDocblockClass>
</file>
<file src="lib/Migration/Version020300Date20210403214012.php">
<InvalidOperand>
<code>$result</code>
<code><![CDATA[$result]]></code>
<code><![CDATA[$this->ensureColumnIsNullable($schema, 'forms_v2_questions', 'mandatory')]]></code>
</InvalidOperand>
</file>
<file src="lib/Migration/Version030000Date20220402100057.php">
<UndefinedClass>
<code>Type</code>
<code><![CDATA[Type]]></code>
</UndefinedClass>
</file>
<file src="lib/Migration/Version030100Date20230115214242.php">
<InvalidOperand>
<code>$result</code>
<code><![CDATA[$result]]></code>
<code><![CDATA[$this->ensureColumnIsNullable($schema, 'forms_v2_options', 'text')]]></code>
<code><![CDATA[$this->ensureColumnIsNullable($schema, 'forms_v2_questions', 'order')]]></code>
<code><![CDATA[$this->ensureColumnIsNullable($schema, 'forms_v2_questions', 'text')]]></code>
<code><![CDATA[$this->ensureColumnIsNullable($schema, 'forms_v2_shares', 'share_type')]]></code>
</InvalidOperand>
</file>
<file src="lib/Service/FormsService.php">
<InvalidThrow>
<code>IMapperException</code>
<code>IMapperException</code>
<code>IMapperException</code>
</InvalidThrow>
</file>
<file src="lib/Service/SubmissionService.php">
<MissingDependency>
<code><![CDATA[$this->storage]]></code>
<code>IRootFolder</code>
<code>IRootFolder</code>
</MissingDependency>
</file>
</files>

0 comments on commit fca8a17

Please sign in to comment.