Bugfix/Correct sort descending lexicographical #2611
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kornél Szekeres <[email protected]>
Signed-off-by: Kornél Szekeres <[email protected]>
Signed-off-by: Kornél Szekeres <[email protected]>
Kokika
force-pushed
the
bugfix/sort-descending-lexicographical
branch
from
31b2496 to
03331be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in my initial descending lexicographical sorting implementation (#2487) where:
🐛 Bug:
Null pointer exception during category sort swich.
Incomplete sorting logic for lexicographical descending sort.
🔧 Fix:
Check for null ptr and initailize for 0.
Sorting applied for category filtering too.
Maintains backward compatibility
✅ Verification:
Validated on my phone with android studio
Confirmed no-breaking changes