Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): lock mdast-util-gfm-autolink-literal library to exact version 2.0.0 #51598

Merged
merged 2 commits into from
Mar 28, 2025
Merged

fix(deps): lock mdast-util-gfm-autolink-literal library to exact version 2.0.0 #51598

merged 2 commits into from
Mar 28, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 20, 2025 •
edited
Loading

Summary

TODO

  • manual test
  • copy solution to another repos using NcRichText (spreed, notifications, deck, e.t.c.), add warning to vue-lib documentation
  • add a hint in vue-lib

Checklist

@Antreesy Antreesy added this to the Nextcloud 32 milestone Mar 20, 2025
@Antreesy Antreesy requested review from susnux and ShGKme March 20, 2025 12:05
@Antreesy Antreesy self-assigned this Mar 20, 2025
@Antreesy
Copy link
Contributor Author

/compile /

@Antreesy Antreesy marked this pull request as ready for review March 27, 2025 19:39
@Antreesy Antreesy requested a review from a team as a code owner March 27, 2025 19:39
skjnldsv
skjnldsv approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof, nice catch

@Antreesy
fix(deps): lock mdast-util-gfm-autolink-literal library to exact vers…
d028b61 
…ion 2.0.0

- this reverts changes from patch update to 2.0.1, which uses 'negative lookbehind' regex and breaks in IOS & Safari versions < 16.4

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/51506/mdast-util-gfm-autolink-literal-override branch from 393e7af to d028b61 Compare March 28, 2025 09:38
@Antreesy
Copy link
Contributor Author

/compile /

@Antreesy
Copy link
Contributor Author

/backport! d028b61 to stable31

@backportbot backportbot bot mentioned this pull request Mar 28, 2025
Closed
@Antreesy
Copy link
Contributor Author

/backport! d028b61 to stable30

@backportbot backportbot bot mentioned this pull request Mar 28, 2025
Closed
@nextcloud-command
chore(assets): Recompile assets
3396298 
Signed-off-by: nextcloud-command <[email protected]>
@Antreesy
Copy link
Contributor Author

/backport! d028b61 to stable29

@Antreesy Antreesy merged commit 48b23e5 into master Mar 28, 2025
139 of 143 checks passed
@Antreesy Antreesy deleted the fix/51506/mdast-util-gfm-autolink-literal-override branch March 28, 2025 10:25
@Antreesy Antreesy mentioned this pull request Mar 28, 2025
Closed
@Antreesy
Copy link
Contributor Author

Should be reverted after nextcloud-libraries/nextcloud-vue#6663 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews dependencies regression
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

[Bug]: safari on ios16 can't access web ui after update to 31.0.1 from 31.0.0, downgrade will resume ok
4 participants
@Antreesy @skjnldsv @ShGKme @nextcloud-command