fix(files_versions): only handle path updates when there is path #51609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getPathForNode` can fail with null for various reasons (e.g. no owner), in this cases we need to just skip the event handling. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
ArtificialOwl,
nfebe and
come-nc
and removed request for
a team
solracsf
approved these changes
Mar 21, 2025
come-nc
reviewed
Mar 24, 2025
| $view = new View(\OC_User::getUser() . '/files'); | ||
| if ($view->file_exists($newPath)) { | ||
| $view = new View($user . '/files'); | ||
| if ($view->file_exists($newPath) === true) { |
There was a problem hiding this comment.
Suggested change
| if ($view->file_exists($newPath) === true) { | |
| if ($view->file_exists($newPath)) { |
Feels dangerous to do a strong comparison here, what’s the reason?
| return; | ||
| } | ||
|
|
||
| $user = \OC_User::getUser(); |
There was a problem hiding this comment.
😿
What’s the reason for getting the current user here?
$node->getPath should return the absolute path already?
Otherwise, use $this->userSession->getUser() like in getPathForNode, as you do not want to skip rename if coming from a public page where incognito mode is active (which is the only added feature of OC_User)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getPathForNodecan fail with null for various reasons (e.g. no owner), in this cases we need to just skip the event handling.Checklist