fix(ocm): publicKey can be disabled so capabilities do not match
#51622
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the public key feature is disabled null is returned for `publicKey`. So in this case we need to adjust the capabilities and return type of `jsonSerialize()`. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
nickvergessen,
a team and
provokateurin
as code owners
susnux
requested review from
artonge and
skjnldsv
and removed request for
a team
|
/backport to stable31 |
provokateurin
approved these changes
Mar 21, 2025
AndyScherzinger
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the public key feature is disabled null is returned for
publicKey. So in this case we need to adjust the capabilities and return type ofjsonSerialize().Checklist