feat: Add share expiration indicator #51630
Open
+152
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
2 times, most recently
from
09fb848 to
7d27f2c
Compare
nfebe
requested review from
susnux,
szaimen,
sorbaugh,
artonge and
marcoambrosini
and removed request for
a team and
szaimen
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
8034a08 to
0c73c87
Compare
marcoambrosini
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Nice @nfebe, the only thing I'd change is I'd put this new icon all the way to the left so that the copy link icons are vertically aligned.
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
0c73c87 to
f834b14
Compare
|
cc: @marcoambrosini |
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
f834b14 to
9e79113
Compare
|
/compile |
Shares that would expire now shows a clock icon with a popover. Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
2 times, most recently
from
fa530fd to
d293d79
Compare
This commit adds the dayjs library as a dependency. New files should use dayjs for date/time formatting and manipulation. Existing files using moment.js will be gradually refactored to dayjs in subsequent commits. Motivation: - Moment.js is a large library with a significant bundle size, which can negatively impact performance. - Dayjs is a smaller, more lightweight alternative with a similar API. - Dayjs is immutable, which is a better practice. - Moment.js is in maintenance mode. This change introduces dayjs to facilitate a gradual migration away from moment.js, improving performance and maintainability in the long term. Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
d293d79 to
94df136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shares that would expire now shows a clock icon with a popover.
Screenshots