Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user): Some strings not being translated #51644

Merged
merged 2 commits into from
Mar 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apps/settings/src/components/Users/UserRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ export default {
})
} catch (error) {
// TRANSLATORS This string describes a line manager in the context of an organization
showError(t('setting', 'Failed to update line manager'))
showError(t('settings', 'Failed to update line manager'))
console.error(error)
} finally {
this.loading.manager = false
Expand Down Expand Up @@ -638,7 +638,7 @@ export default {
})

if (this.editedDisplayName === this.user.displayname) {
showSuccess(t('setting', 'Display name was successfully changed'))
showSuccess(t('settings', 'Display name was successfully changed'))
}
} finally {
this.loading.displayName = false
Expand All @@ -651,7 +651,7 @@ export default {
async updatePassword() {
this.loading.password = true
if (this.editedPassword.length === 0) {
showError(t('setting', "Password can't be empty"))
showError(t('settings', "Password can't be empty"))
this.loading.password = false
} else {
try {
Expand All @@ -661,7 +661,7 @@ export default {
value: this.editedPassword,
})
this.editedPassword = ''
showSuccess(t('setting', 'Password was successfully changed'))
showSuccess(t('settings', 'Password was successfully changed'))
} finally {
this.loading.password = false
}
Expand All @@ -674,7 +674,7 @@ export default {
async updateEmail() {
this.loading.mailAddress = true
if (this.editedMail === '') {
showError(t('setting', "Email can't be empty"))
showError(t('settings', "Email can't be empty"))
this.loading.mailAddress = false
this.editedMail = this.user.email
} else {
Expand All @@ -686,7 +686,7 @@ export default {
})

if (this.editedMail === this.user.email) {
showSuccess(t('setting', 'Email was successfully changed'))
showSuccess(t('settings', 'Email was successfully changed'))
}
} finally {
this.loading.mailAddress = false
Expand Down Expand Up @@ -890,7 +890,7 @@ export default {
sendWelcomeMail() {
this.loading.all = true
this.$store.dispatch('sendWelcomeMail', this.user.id)
.then(() => showSuccess(t('setting', 'Welcome mail sent!'), { timeout: 2000 }))
.then(() => showSuccess(t('settings', 'Welcome mail sent!'), { timeout: 2000 }))
.finally(() => {
this.loading.all = false
})
Expand Down
4 changes: 2 additions & 2 deletions dist/settings-users-3239.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-users-3239.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/settings-vue-settings-apps-users-management.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-vue-settings-apps-users-management.js.map

Large diffs are not rendered by default.

Loading