feat(files_versions): get revision for a node

[bdovaz]

• Resolves: Provide a more secure method of obtaining the revision id from a Node when file versioning is used. #52092

Summary

Encapsulate the implementation detail of how the revision is resolved through a node.

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[provokateurin]

Not sure how useful this is, but it certainly won't hurt either.

[bdovaz]

Not sure how useful this is, but it certainly won't hurt either.

As I put in my original issue, the utility is not having to know the detail of how the revision int is resolved.... The APi of file_revisions is not intuitive in this sense...

I had to go to VersionAuthorListener to deduce how a revision is resolved from a node (getMTime)

[provokateurin]

Please squash your commits and format the commit message to use conventional commits.

[bdovaz]

Please squash your commits and format the commit message to use conventional commits.

I understand that you are referring to the DCO issue. Resolved!

[susnux]

I understand that you are referring to the DCO issue. Resolved!

Yes but please also squash them into one commit and give them a proper commit message according to conventional commits.

[bdovaz]

Yes but please also squash them into one commit

Are there any instructions on which git commands to use in a readme file in the repository? I've never done this before manually.

Whenever I squash, it's when merging the PR through GitHub or Azure DevOps tools.

[susnux]

Are there any instructions on which git commands to use in a readme file in the repository? I've never done this before manually.

Squash:

# update references
git fetch --all
# interactive rebase - adjust `origin` with the name of the upstream repository (this one here)
git rebase -i origin/master
# now in the opened editor mark all except the first as "s" (for squash)
# save and follow the instructions git prompts you with
git push -f

[bdovaz]

@susnux thank you, I think I did it right.

[bdovaz]

@provokateurin I must have done something wrong. Do you know what it could be?

[provokateurin]

The class LegacyVersionsBackend also needs to have the getRevision method implemented to fulfill the interface.

[provokateurin]

@bdovaz please squash again, we can't merge it like this.

[bdovaz]

Ready (I hope)

[bdovaz]

Are the problems that arise caused by my PR? Because apparently it doesn't seem so.

[provokateurin]

No, they can be ignored because your PR is coming from a fork.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)