Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message of type actorId "sample" should show talk logo avatar #4663

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Message of type actorId "sample" should show talk logo avatar #4663

merged 1 commit into from
Jan 28, 2025

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Jan 28, 2025 •
edited
Loading

Resolve #4602

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch force-pushed the show_changelog_avatar branch from 91ba212 to c7c287a Compare January 28, 2025 10:01
@sowjanyakch sowjanyakch self-assigned this Jan 28, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4663-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 0918cdd into master Jan 28, 2025
19 checks passed
@mahibi mahibi deleted the show_changelog_avatar branch January 28, 2025 10:35
@mahibi mahibi added this to the 21.1.0 milestone Jan 28, 2025
@mahibi
Copy link
Collaborator

mahibi commented Jan 28, 2025

/backport to stable-21.0

@backportbot backportbot bot mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.1.0
Development

Successfully merging this pull request may close these issues.

Show changelog-avatar for additional case
2 participants
@sowjanyakch @mahibi