Fixing NPE in ConversationInfoActivity

[rapterjet2004]

• tries to fix NPE for conversation in ConversationInfoActivity #4750

Made the room and capabilities logic synchronous. I don't think there was a race condition, although I didn't verify, but rather I'm leaning towards conversation being overwritten twice, perhaps a double call of the ChatNetworkDataSource.getRoom?

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4792-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	100	100
Errors	9	9

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	222	222
Dodgy code	71	71
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	310	310

[mahibi]

now that we switch(ed) to coroutines we should no longer use blocking calls anymore.

If you find some time, could you try to find the root cause?
I think with a better usage of coroutines we may be able avoid this, although i still fail to understand how conversation can be null.

The blocking calls are at most a temporary solution if we fail to find the root cause for now