Skip to content

reorder + minor changes to gradle.properties #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

reorder + minor changes to gradle.properties #5550

wants to merge 2 commits into from

Conversation

@mahibi
Copy link
Collaborator

@mahibi mahibi commented Nov 13, 2025 •
edited
Loading

adapt gradle.properties to same structure from android files to see differences more easily

change minor settings to adapt android files config

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this Nov 13, 2025
@mahibi mahibi force-pushed the improveGradleAndMemorySettings branch 3 times, most recently from 061cf9e to 2bff8a8 Compare November 19, 2025 17:35
@mahibi mahibi force-pushed the improveGradleAndMemorySettings branch from 2bff8a8 to 963f69f Compare November 27, 2025 15:22
@mahibi mahibi added the 3. to review Waiting for reviews label Nov 27, 2025
@mahibi mahibi requested a review from sowjanyakch November 27, 2025 15:23
@mahibi mahibi requested a review from rapterjet2004 November 27, 2025 15:23
@mahibi mahibi added this to the 23.0.0 milestone Nov 27, 2025
@mahibi mahibi changed the title Improve gradle and memory settings reorder + minor changes to gradle.properties Nov 27, 2025
@mahibi
reorder values to align with android files app
ffaec21 
.. to get a better overview. no values are changed yet.

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi
improve gradle.properties config
f8c08ec 
adapt to android files config in most things, except:

nonTransitiveRClass=false
-> should be set to true in the future. resource handling will have to be optimized, esp. don't use chatkit resources

enableJetifier=true
-> should be removed in the future. We should try to get rid of old dependencies for it.

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the improveGradleAndMemorySettings branch from 963f69f to f8c08ec Compare November 28, 2025 07:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5550.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

At least 1 approving review is required to merge this pull request.

Assignees

@mahibi mahibi

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mahibi @rapterjet2004