fix(files): add tiptap-text-direction extension to support RTL
#6874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
requested review from
max-nextcloud and
mejo-
as code owners
There was a problem hiding this comment.
The test failures look related as now dir="ltr" is include in some of the html output of the unit tests. I think you can just adjust the expectation to match the actual outcome - and we get a test for this extension for free.
Other than that and the linter fix this looks great. Thanks for looking into it!
Would be nice if we could backport it as I think it really fixes a UX bug for rtl and mixed language use.
| @@ -43,6 +43,7 @@ import TaskList from './../nodes/TaskList.js' | |||
| import Text from '@tiptap/extension-text' | |||
| import TrailingNode from './../nodes/TrailingNode.js' | |||
| /* eslint-enable import/no-named-as-default */ | |||
| import TextDirection from 'tiptap-text-direction' | |||
There was a problem hiding this comment.
Ah... this also triggers the import/no-named-as-default eslint rule. So please move it one line up so it's in the eslint-disable block above.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Now it is possible to detect RTL writing style for languages, which requires RTL. Using https://github.com/amirhhashemi/tiptap-text-direction extension. This version works for:
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)