Fix runtime type reflection in nf-lang#7077
Merged
bentsherman merged 1 commit intomasterfrom Apr 27, 2026
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
bentsherman
force-pushed
the
fix-runtime-type-reflection
branch
from
1dcbf53 to
bb13792
Compare
jorgee
approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Changes looks fine. Just a comment I noted here and I missed in the other PR. The plugin spec type can have a String or a Map with name and typeArguments. It is only used to write the plugin spec. Not sure who is using this spec. Could it create incompatibilities with other tools using specs generated with this PR.
Member
Author
|
It is currently only used by the language server, which already supports both string and map |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spun out from #7025 to make that PR more focused
This PR fixes the runtime type reflection in nf-lang to handle parameterized types correctly, using
TypeandParameterizedTypein addition toClass.It improves both the rendering of type names (e.g. in error messages) and the extraction of types in plugin specs (e.g. config option types, function parameter/return types).
This fix is also needed by the language server to accurately type-check plugin definitions.