Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the HTTP request implementation in the ngstd library to use Qt's QNetworkAccessManager instead of GDAL's CPLHTTPFetch functions. This is a significant architectural change that modernizes the HTTP request handling while maintaining the same external API.
Changes:
- Replaced GDAL CPL HTTP functions with Qt QNetworkAccessManager for all HTTP operations
- Implemented custom retry logic, timeout handling, and SSL error handling using Qt's networking classes
- Added helper functions for request execution, JSON parsing, and proxy credential resolution
- Migrated OAuth token refresh, file upload, and all GET/POST operations to the new implementation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 19 comments.
| File | Description |
|---|---|
| src/core/request.h | Added two new public methods: timeout() and retryDelay() to expose configuration values |
| src/core/request.cpp | Complete refactoring of HTTP request logic from GDAL CPL to QNetworkAccessManager with new helper functions, retry logic, and error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
514ckw4r3
force-pushed
the
dev/NGQ-231
branch
from
d619509 to
ca55892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Переделал запросы в ngstd через QNetworkAccessManager