XIOS: Handle DGSField
#952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewallwork
added
enhancement
TomMelt
approved these changes
Oct 21, 2025
Contributor
TomMelt
left a comment
TomMelt
left a comment
There was a problem hiding this comment.
Super thanks @jwallwork23 this also looks hot to go 🔥
joewallwork
force-pushed
the
issue917_xios-write-diag-time
branch
from
0e09b2c to
c11c35a
Compare
joewallwork
force-pushed
the
issue911_xios-dgs
branch
from
1006aa6 to
7ab746e
Compare
Contributor
Author
|
[Rebased on top of issue917_xios-write-diag-time] |
Contributor
Author
|
I'm going to go ahead and merge this given that @timspainNERSC approved #951 and the changes here take a similar form - just for a different discretisation. |
joewallwork
added a commit
that referenced
this pull request
Nov 10, 2025
# XIOS: Handle `CGField` Fixes #911 Merges into #952 ### Task List - [x] Defined the tests that specify a complete and functioning change (*It may help to create a [design specification & test specification](../../../wiki/Specification-Template)*) - [x] Implemented the source code change that satisfies the tests - [x] Documented the feature by providing worked example - [x] Updated the README or other documentation - [x] Completed the pre-Request checklist below --- # Change Description Currently the XIOS implementation accounts for `HField`, `VertexField`, and `DGField`. #952 extends to cover `DGSField`. This PR extends further to cover `CGField`. This involved checking the global and local dimensions and start index are set up correctly, as well as the XIOS domain, grid, and field. Several error messages were also made clearer as part of this change. --- # Test Description The XIOS read and write tests are updated to account for the CG field type. A minor looping issue is also fixed in the value checking - it was missing the final value for `VertexField`. As such, the value checking code in `XiosRead_test` was reworked to loop over fields first and then dimensions. To make this easier to check, I changed the coordinate field to align with the coordinates of the grid (assuming unit spacing in each direction). Note that the file reading code accounts for halos out-of-the-box! :angel: --- # Documentation Impact `CGField` is mentioned in the XIOS docs page. --- ### Pre-Request Checklist - [x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR - [x] No new warnings are generated - [x] The documentation has been updated (or an issue has been created to track the corresponding change) - [x] Methods and Tests are commented such that they can be understood without having to obtain additional context - [x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change - [x] This change conforms to the conventions described in the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XIOS: Handle
DGSFieldTowards #911
Merges into #934
Task List
Change Description
Currently the XIOS implementation accounts for
HField,VertexField, andDGField. This PR extends it to coverDGSField.Test Description
The XIOS read and write tests are updated to account for this field type.
Documentation Impact
The XIOS docs page is updated to mention
DGSFieldand the fact the field type needs to be set in the case of file writing.Pre-Request Checklist