File behaviour for restarts and diagnostics #989
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewallwork
added
bug
joewallwork
force-pushed
the
issue935_xios-landmask
branch
from
5ae4048 to
8b5f23a
Compare
… splitting for now
joewallwork
changed the base branch from
develop
to
issue990_xios_write-then-read-take3
joewallwork
force-pushed
the
issue935_xios-landmask
branch
from
8b5f23a to
dfa80d5
Compare
Otherwise, it will be zeroed in file splits after the first
joewallwork
force-pushed
the
issue990_xios_write-then-read-take3
branch
from
3582343 to
c16977a
Compare
joewallwork
force-pushed
the
issue935_xios-landmask
branch
from
dfa80d5 to
33e0a3e
Compare
joewallwork
force-pushed
the
issue990_xios_write-then-read-take3
branch
4 times, most recently
from
183435f to
279efaa
Compare
joewallwork
force-pushed
the
issue990_xios_write-then-read-take3
branch
from
279efaa to
e157a0c
Compare
This was
linked to
issues
Dec 2, 2025
Base automatically changed from
issue990_xios_write-then-read-take3
to
develop
December 4, 2025 13:02
joewallwork
commented
Dec 5, 2025
| config << "stop = 2023-03-17T23:11:00Z" << std::endl; | ||
| config << "time_step = P0-0T01:30:00" << std::endl; | ||
| config << "init_file = " << restartFilename << std::endl; | ||
| config << "restart_period = P0-0T01:30:00" << std::endl; |
Contributor
Author
There was a problem hiding this comment.
The restart period needs to be provided, otherwise XIOS stalls.
Contributor
Author
|
Superseded by #1002. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File behaviour for restarts and diagnostics
Fixes #935
Fixes #977
Fixes #997
Fixes #898
Merges into #999Task List
Change Description
This PR fixes several things related to how restarts and diagnostics are configured with XIOS:
Whilst file patterns are made consistent with what's used elsewhere in nextSIM-DG, the output filenames show the range of datetimes separated by a hyphen.
In this PR, I also overhauled the
createFilemember function, inlining many of the setters with only a single call site.Test Description
Tests are updated to account for the new behaviour.
TODO - to test the diagnostics are written out.
I decided to drop
XiosFile_testbecause it is no longer needed. This meant that we could drop the annoyingunittestspecial case.Documentation Impact
TODO
Pre-Request Checklist