docs: fix Manual Edit protocol summaries to match implemented contracts - #6608
Open
xxiaoxiong wants to merge 1 commit into
Open
docs: fix Manual Edit protocol summaries to match implemented contracts#6608xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
…ts (6141)
Two lines in the v2.3/v2.4 protocol summary were stale:
- od-edit-paste-image payload: {id, file} → {id, name, mime, buffer}
- od-edit-apply-dom ops: added insert-at-index and apply-content
The runtime implementation (bridge, source-patches, FileViewer) already
uses the complete contracts; only the spec summary lines were out of sync.
Contributor
|
Thanks @xxiaoxiong — these two corrections look on point. The |
2 tasks
mrcfps
approved these changes
Aug 7, 2026
mrcfps
left a comment
Contributor
There was a problem hiding this comment.
@xxiaoxiong Thanks for the clean docs fix on a good-first-issue — appreciated!
I verified the two protocol summary updates in specs/current/manual-edit-direct-manipulation.zh-CN.md:
- v2.3
od-edit-paste-imagesummary now uses{id, name, mime, buffer}, matching the detailed section just above (line 78) and the historical typed bridge contract (ManualEditPasteImageMessage/ byte payload for clipboard and drag Files). - v2.4
od-edit-apply-domsummary now includesinsert-at-indexandapply-content, matching the surrounding architecture prose (brand runtime targets / body-child restore) and the hostapplyManualEditDomOpop union.
Pure documentation change, internally consistent, no runtime risk. Nice surgical fix.
🔁 Powered by Looper · runner=reviewer · agent=grok-build · An autonomous AI dev team for your GitHub repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two stale protocol summary lines in
specs/current/manual-edit-direct-manipulation.zh-CN.mdthat contradict the live implementation (issue #6141, labeledgood first issue+help wanted).Changes
od-edit-paste-image payload (v2.3 summary)
{id, file}{id, name, mime, buffer}{id, name, mime, buffer}because the clipboard/dragFilehandle may be neutered after the event turn, so bytes must cross the iframe boundary.od-edit-apply-dom operations (v2.4 summary)
replace|insert-after|append-child|prepend-child|removereplace|insert-after|insert-at-index|append-child|prepend-child|remove|apply-contentinsert-at-indexis used to restore a removed body child at its original index;apply-contentmirrors edits for runtime-annotated brand targets without reloading the iframe.Scope
Pure documentation fix (2 lines changed). No runtime code changes needed. The implementation already matches the corrected contracts.