fix: return Result from VersionChecker::new instead of panicking on TLS init failure#2093
Open
amathxbt wants to merge 1 commit into
Open
fix: return Result from VersionChecker::new instead of panicking on TLS init failure#2093amathxbt wants to merge 1 commit into
amathxbt wants to merge 1 commit into
Conversation
ClientBuilder::build() can fail when the TLS stack is unavailable (certain minimal container images, FIPS-restricted environments, or broken system rootcas). The current code calls .expect() which terminates the entire CLI process before the user can do anything useful. Change new() to return Result<Self, reqwest::Error> and update check_for_new_version to treat a construction failure as non-fatal, returning None (no update message) instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VersionChecker::newcalls.expect()on thereqwest::ClientBuilder::build()result:ClientBuilder::buildcan fail when the TLS backend cannot be initialised — for example in minimal container images without system CA certificates, or in FIPS-restricted environments. Theexpectturns this initialisation error into an unconditional process abort, preventing the CLI from starting at all even though the version check is entirely optional.Fix
Change
newtonew(current_version: String) -> Result<Self, reqwest::Error>and propagate the error with?. Updatecheck_for_new_versionto treat anewfailure as non-fatal (returnNonerather than crashing).