FASTQREPAIR first release #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important! Template update for nf-core/tools v3.2.0
…th WIPERTOOLS_REPORTGATHER and WIPERTOOLS_FASTQGATHER, update publishDir logic, and remove unused modules.
@charles-plessy tests won't pass as per this thread: https://nfcore.slack.com/archives/C050DNB6K5H/p1738075793257549?thread_ts=1738010902.014759&cid=C050DNB6K5H |
atrigila
approved these changes
Jan 28, 2025
jfy133
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Fantastic work converting all your local modules to offical nf-core ones @mazzalab !
And adding tests for local subworkflows too!
I've left a few minor comments, which should ideally be addressed (not blockers) but otherwise this looks ready to me!
LouisLeNezet
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first release PR.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).