-
Notifications
You must be signed in to change notification settings - Fork 35
Gecco convert #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gecco convert #506
Changes from 9 commits
fa9db01
5a2afa6
0012b8a
518a7a1
f636670
0fd918f
a1bcca7
8e4f163
f5ff043
686b2ff
ed55447
242592d
a5d0119
ecfdfd3
81b1160
43a2964
2e62888
c9244b7
000326b
d6a9dcb
8104d87
ecd72c7
fb9a4ff
df1e3ac
a9a561a
47a9254
e789973
1ec8cee
a06d281
de6c87a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1418,6 +1418,34 @@ | |||||
| }, | ||||||
| "fa_icon": "fas fa-angle-double-right" | ||||||
| }, | ||||||
|
|
||||||
| "gecco_options": { | ||||||
| "title": "GECCO biosynthetic gene cluster prediction options", | ||||||
| "type": "object", | ||||||
| "description": "Parameters for running GECCO BGC prediction", | ||||||
| "default": "", | ||||||
| "properties": { | ||||||
| "run_gecco_convert": { | ||||||
|
||||||
| "run_gecco_convert": { | |
| "bgc_gecco_runconvert": { |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I misunderstand #450 , this phrasing is confusing to me.
I thought (and the code says) you run GECCO_CONVERT after GECCO_RUN to convert the files to other formats for downstream processes, not to convert input files into one that GECCO accepts.
Could you please reprhase or re-explain to me the purposes of the GECCO_CONVERT module (I'm not that familiar1)
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "gecco_convert_mode": { | |
| "bgc_gecco_convertmode": { |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does custom mean here though - where does a user specify the additional paramaeters?
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "gecco_convert_format": { | |
| "bgc_gecco_convertformat": { |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,6 +12,7 @@ include { DEEPBGC_PIPELINE } from '../../modules/nf-core/d | |||||
| include { COMBGC } from '../../modules/local/combgc' | ||||||
| include { TABIX_BGZIP as BGC_TABIX_BGZIP } from '../../modules/nf-core/tabix/bgzip/main' | ||||||
| include { MERGE_TAXONOMY_COMBGC } from '../../modules/local/merge_taxonomy_combgc' | ||||||
| include { GECCO_CONVERT } from '../../modules/nf-core/gecco/convert/main' | ||||||
|
|
||||||
| workflow BGC { | ||||||
| take: | ||||||
|
|
@@ -104,6 +105,18 @@ workflow BGC { | |||||
| ch_bgcresults_for_combgc = ch_bgcresults_for_combgc.mix(ch_geccoresults_for_combgc) | ||||||
| } | ||||||
|
|
||||||
| // GECCO CONVERT | ||||||
| if (params.run_gecco_convert) { | ||||||
|
||||||
| if (params.run_gecco_convert) { | |
| if (params.bgc_gecco_runconvert) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the rest of the parameter system.
Make sure to update the parameters throughout the code base too