Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aarch64 support #134

Open
wants to merge 22 commits into
base: pipeline_v6.0
Choose a base branch
from

Conversation

brainstorm
Copy link

@brainstorm brainstorm commented Feb 25, 2025

@brainstorm
Copy link
Author

Similar to #129, but don't close this yet, @scwatts, work in progress ;)

@scwatts scwatts added this to the Release 2.1.0 milestone Feb 25, 2025
@scwatts scwatts added the enhancement New feature or request label Feb 25, 2025
@scwatts
Copy link
Collaborator

scwatts commented Feb 25, 2025

@brainstorm can you please take a look at adding ARM64 support for ESVEE 1.0? See here for logs of Wave build failure

@@ -2,6 +2,7 @@ process STAR_ALIGN {
tag "${meta.id}"
label 'process_high'

conda "${moduleDir}/environment.yml"
Copy link
Collaborator

@scwatts scwatts Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is pending elsewhere :) Could you please not include this in the final PR?

… recent sambamba version. We'll have to make a second pass when singularity/biocontainers get the new release for hmftools-esvee from bioconda, later on
-known_hotspot_file: type(PATH) desc(Known
fusion hotspot BED file)

Command error:
  06:51:31.804 [ERROR] unregistered config item: -known_fusion_file
  06:51:31.806 [INFO ] registered config items:
  06:51:31.806 [INFO ]  -bam_file: type(PATHS) desc(BAM file paths separated by ',')
  06:51:31.806 [INFO ]  -bam_validation: default(LENIENT) desc(BAM validation: STRICT (default), LENIENT or SILENT)
  06:51:31.806 [INFO ]  -bamtool: type(PATH) desc(Path to sambamba or samtools for sort/merge)
  06:51:31.806 [INFO ]  -blacklist_bed: type(PATH) desc(Blacklist regions BED file)
  06:51:31.806 [INFO ]  -known_hotspot_file: type(PATH) desc(Known fusion hotspot BED file)
  06:51:31.806 [INFO ]  -log_debug: type(FLAG) desc(Log at DEBUG level)
  06:51:31.806 [INFO ]  -log_level: desc(Specify log level: ERROR, WARN, INFO, DEBUG or TRACE)
  06:51:31.806 [INFO ]  -log_read_ids: desc(Log specific read IDs, separated by ';')
  06:51:31.806 [INFO ]  -low_base_qual: type(INTEGER) default(26) desc(Level below which a base is consider low-quality)
  06:51:31.806 [INFO ]  -max_frag_length_override: type(INTEGER) default(-1) desc(Set max fragment length instead of calculating)
  06:51:31.806 [INFO ]  -min_align_bases: type(INTEGER) default(50) desc(Junction fragment min aligned bases)
  06:51:31.806 [INFO ]  -min_junction_frags: type(INTEGER) default(2) desc(Required fragments to keep a junction)
  06:51:31.806 [INFO ]  -no_cache_bam: type(FLAG) desc(Write a BAM to cache candidate reads)
  06:51:31.806 [INFO ]  -no_clean_up: type(FLAG) desc(Keep candidate cache BAM files)
  06:51:31.806 [INFO ]  -no_trim_read_id: type(FLAG) desc(Disable use of a shortened readId internally)
  06:51:31.806 [INFO ]  -output_dir: desc(Output directory)
  06:51:31.806 [INFO ]  -output_id: desc(Output file suffix)
  06:51:31.806 [INFO ]  -partition_size: type(INTEGER) default(1000000) desc(Partition size)
  06:51:31.806 [INFO ]  -perf_debug: type(FLAG) desc(Detailed performance tracking and logging)
  06:51:31.807 [INFO ]  -read_length: type(INTEGER) default(151) desc(Read length)
  06:51:31.807 [INFO ]  -ref_genome: type(PATH) REQUIRED desc(Path to reference genome fasta files)
  06:51:31.807 [INFO ]  -ref_genome_version: REQUIRED desc(Ref genome version, 37 or 38)
  06:51:31.807 [INFO ]  -sample: desc(List of samples separated by ',')
  06:51:31.807 [INFO ]  -sequencing_type: default(ILLUMINA) desc(Sequencing types: ILLUMINA, ULTIMA, SBX, BIOMODAL)
  06:51:31.807 [INFO ]  -specific_chr: desc(Restrict to chromosome(s) separated by ';')
  06:51:31.807 [INFO ]  -specific_regions: desc(Restrict to regions(s) separated by ';' in format Chr:PosStart:PosEnd or Chr:PosStart-PosEnd)
  06:51:31.807 [INFO ]  -threads: type(INTEGER) default(1) desc(Number of threads, 0 or 1 not multi-threaded)
  06:51:31.807 [INFO ]  -track_remotes: type(FLAG) desc(Track support for remote junctions)
  06:51:31.807 [INFO ]  -write_types: desc(Write types: PREP_JUNCTION;PREP_READ;PREP_BAM;UNSORTED_BAM;CACHE_BAM;FRAGMENT_LENGTH_DIST;DISCORDANT_STATS separated by ';')
@brainstorm brainstorm marked this pull request as ready for review March 14, 2025 07:17
@brainstorm
Copy link
Author

brainstorm commented Mar 17, 2025

Work left to do for final merge/inclusion:

  1. Downgrade on some of the versions (ESVEE and others are “too new” for accreditation purposes).
  2. Pull request against Hartwig to get gatk-bwamem-jni dependency accepted upstream (instead of patching bioconda/conda-forge instead).
  3. Repoint custom hmftools-esvee from my Anaconda brainstorm channel to bioconda (after 2 is done).
  4. @scwatts, probably we should merge this branch into the dev branch so that
    Phil Ewel re-runs nf-core-discovery repo (which targets dev branches on all third party pipelines)?
  5. Rollback STAR-align module change in Aarch64 support #134 (comment).
  6. Re-run on Intel vs Aarch64 instances (c7a.4xlarge vs c8g.4xlarge, as suggested by David Lecomber) and enable AWS split cost allocation data for both runs.

/cc @ohofmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants