-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.0.0 #45
Open
charles-plessy
wants to merge
37
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release v2.0.0 #45
+1,755
−1,190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files are not expected to be useful for downstream analyses and can be re-created identically if they were ever needed. Advanced users can also override the `publishDir` directive.
The alignment files take significant amount of disk space. Most users of the standard mode are only interested in the _one-to-one_ alignments. With that change, the intermediate alignment files are only kept in the `--m2m` mode, which is expected to be selected only by users interested in these alignments. Closes #30. Output is optional in the sense that one can always use `--m2m` to get the _many-to-one_ alignment even if not interested in the _one-to-many_.
Closes #29 When aligning a target to a large number of queries, it is sometimes impossible to know in advance if each of them is really alignable. Ignoring the error is a much better outcome than interrupting the pipeline and asking the user run the pipeline again after removing the problematic genomes from the sample sheet (or running again with a more sensitive seed). Errors caused by lack of memory etc. are still errors.
The update of LAST changes some alignment parameters, and therefore can change the pipeline results. Therefore this is a major upgrade.
Quoting from <https://www.debian.org/doc/debian-policy/ch-controlfields.html#version>: > The lexical comparison is a comparison of ASCII values modified so that all the letters sort earlier than all the non-letters and so that a tilde sorts before anything, even the end of a part. For example, the following parts are in sorted order from earliest to latest: ~~, ~~a, ~, the empty part, a. Co-authored-by: James A. Fellows Yates <[email protected]>
Important! Template update for nf-core/tools v3.1.2
…into milestone_2.0.0
Important! Template update for nf-core/tools v3.2.0
Also updated MultiQC version in CHANGELOG.md and refreshed ro-crate-metadata.json.
Bring back merge commits from `master` to `dev`
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
…into milestone_2.0.0
Also pull the fix for the versions channel of last/train (see <nf-core/modules#7393>)
Milestone 2.0.0
tanyasarkjain
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to release
dev
as version2.0.0
, to bring fixes and updates to users. Here is a copy of the changelog:v2.0.0 "Naga imo" - [January 31st, 2025]
Breaking changes
parameters. The alignments ran with this pipeline will not be identical to
the ones from older versions.
Added
alignment/lastdb
directory is not output anymore. It consumed space,is not usually needed for downstream analysis, and can be re-computed
identically if needed.
space. To keep this file, you can run the pipeline in
many-to-many
modewith the
--m2m
parameter.--seed
parameter allows for all the existing values in thelastdb
program.
are now ignored.
--export_aln_to
that creates additional files containingthe alignments in a different format such as Axt, Chain, GFF or SAM.
Fixed
N
s was corrected (#18).--lastal_params
now works as intended instead of being ignored (#22).Parameters
--export_aln_to
Dependencies
LAST
MultiQC
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).