Fix shapeit5 hash divergence#298
Open
LouisLeNezet wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
This PR fix the reproducibility issue with singularity on some machine.
After a lot of debugging this seemed to come from the
vcf.gzformat and.tbiindex that when given toSHAPEIT5_phase_commonwould result in different phase for some individuals for just a few position but still throwing off the variants md5sum result.To solve this without adding an extra module,
VCFLIB_VCFFIXUPmodule was updated to output any vcf format + index.This removed one module necessary and stabilised the hash.
See https://nfcore.slack.com/archives/C04PPJLT1T3/p1781099185452859 for the full rubber ducking.
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).