Skip to content

Fix shapeit5 hash divergence#298

Open
LouisLeNezet wants to merge 12 commits into
nf-core:devfrom
LouisLeNezet:fix_shapeit5_hash
Open

Fix shapeit5 hash divergence#298
LouisLeNezet wants to merge 12 commits into
nf-core:devfrom
LouisLeNezet:fix_shapeit5_hash

Conversation

@LouisLeNezet

@LouisLeNezet LouisLeNezet commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

PR checklist

This PR fix the reproducibility issue with singularity on some machine.
After a lot of debugging this seemed to come from the vcf.gz format and .tbi index that when given to SHAPEIT5_phase_common would result in different phase for some individuals for just a few position but still throwing off the variants md5sum result.

To solve this without adding an extra module, VCFLIB_VCFFIXUP module was updated to output any vcf format + index.
This removed one module necessary and stabilised the hash.

See https://nfcore.slack.com/archives/C04PPJLT1T3/p1781099185452859 for the full rubber ducking.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet requested a review from atrigila June 11, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant