-
Notifications
You must be signed in to change notification settings - Fork 17
feat: Add riboWaltz MultiQC custom content integration #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pinin4fjords
wants to merge
12
commits into
dev
Choose a base branch
from
feature/ribowaltz-multiqc-integration
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ribowaltz_to_mqc.py script to transform riboWaltz TSV outputs to MultiQC custom content format (psite regions, frames, metaprofiles) - Create local RIBOWALTZ_MQC module to run the transform script - Create RIBOWALTZ_QC local subworkflow to encapsulate riboWaltz logic - Update riboWaltz module to export underlying data as TSV for all QC plots - Add riboWaltz to MultiQC top_modules for proper section ordering - Configure publishDir for riboWaltz outputs (QC to riboseq_qc/, coverage to other/) The MultiQC integration includes: - P-site region distribution bar chart with RNA-seq reference - Reading frame distribution grouped by transcript region - Metaprofile line graphs for start and stop codons 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Replace top_modules with numeric report_section_order to properly control the position of riboWaltz and other custom content sections in the MultiQC report.
Add report_section_order entries for preprocessing, alignment, and post-alignment QC sections so riboWaltz appears in the correct position (after alignment stats, before downstream analysis).
Add anchor properties to FastQC entries so they can be referenced by fastqc_raw and fastqc_trimmed in report_section_order.
Member
Author
|
Example: multiqc_report.html |
iraiosub
approved these changes
Jan 5, 2026
Contributor
iraiosub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the multiQC report looks very neat! Feel free to merge after tests pass.
Simplify channel operations by using a single branch operator instead of three separate map/flatten/filter chains. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Extract common constants (PARENT_ID, PARENT_NAME, PARENT_DESC, REGIONS) - Add read_tsv_files() generator for DRY file reading - Add print_bargraph_header() helper for repeated YAML output - Simplify transform_metaprofile() using string formatting - Use dispatch dict instead of if/elif chain 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
The ribowaltz PDFs are published to riboseq_qc/ribowaltz/, not ribowaltz/. This covers both offset_plot/ and ribowaltz_qc/ subdirectories. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
PDF files are non-deterministic and should not be checksummed. The .nftignore already excludes them from future snapshots. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
Author
|
I'm closing this for now, we're going to make it a MultiQC plugin and avoid the complexity caused by the custom content |
Contributor
|
that sounds great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ribowaltz_to_mqc.pyscript to transform riboWaltz TSV outputs to MultiQC custom content formatRIBOWALTZ_MQCmodule andRIBOWALTZ_QCsubworkflow to encapsulate riboWaltz logicriboseq_qc/, coverage toother/)The MultiQC integration includes:
Test plan
🤖 Generated with Claude Code