Skip to content

Commit 8ce68db

Browse files
authored
Merge pull request #1654 from nf-core/tximport_fix
fix(tximport): handle tx2gene files with extra columns
2 parents e6739b0 + 4ef1313 commit 8ce68db

File tree

9 files changed

+435
-131
lines changed

9 files changed

+435
-131
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
### Enhancements and fixes
1111

12+
- [PR #1654](https://github.com/nf-core/rnaseq/pull/1654) - Fix tximport to handle tx2gene files with extra columns from `--gtf_extra_attributes`, and fix sample name mangling in DESeq2 QC
1213
- [PR #1655](https://github.com/nf-core/rnaseq/pull/1655) - Fix duplicate flagstat files in MultiQC report when mark duplicates is enabled ([#1653](https://github.com/nf-core/rnaseq/issues/1653))
1314
- [PR #1656](https://github.com/nf-core/rnaseq/pull/1656) - Bump version after release 3.22.1
1415
- [PR #1658](https://github.com/nf-core/rnaseq/pull/1658) - Bump nf-core/multiqc module to 1.33

bin/deseq2_qc.r

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ if (is.null(opt$count_file)){
5555
################################################
5656
################################################
5757

58-
count.table <- read.delim(file=opt$count_file,header=TRUE, row.names=NULL)
58+
count.table <- read.delim(file=opt$count_file,header=TRUE, row.names=NULL, check.names=FALSE)
5959
rownames(count.table) <- count.table[,opt$id_col]
6060
count.table <- count.table[,opt$count_col:ncol(count.table),drop=FALSE]
6161
colnames(count.table) <- gsub(opt$sample_suffix,"",colnames(count.table))
@@ -76,7 +76,7 @@ samples.vec <- colnames(count.table)
7676
name_components <- strsplit(samples.vec, "_")
7777
n_components <- length(name_components[[1]])
7878
decompose <- n_components!=1 && all(sapply(name_components, length)==n_components)
79-
coldata <- data.frame(samples.vec, sample=samples.vec, row.names=1)
79+
coldata <- data.frame(sample=samples.vec, row.names=samples.vec)
8080
if (decompose) {
8181
groupings <- as.data.frame(lapply(1:n_components, function(i) sapply(name_components, "[[", i)))
8282
n_distinct <- sapply(groupings, function(grp) length(unique(grp)))

modules.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@
269269
},
270270
"tximeta/tximport": {
271271
"branch": "master",
272-
"git_sha": "d205ebc03abc530a984d844ab57373f566967ac8",
272+
"git_sha": "9ef7553c32b02bc33ecb962b5f07a8cb16b2117c",
273273
"installed_by": ["modules", "quantify_pseudo_alignment"]
274274
},
275275
"ucsc/bedclip": {

modules/nf-core/tximeta/tximport/meta.yml

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/tximeta/tximport/templates/tximport.r

Lines changed: 50 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/tximeta/tximport/tests/main.nf.test

Lines changed: 102 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)